Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[misc](library): disable ytdl by default #900

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Conversation

cosven
Copy link
Member

@cosven cosven commented Jan 31, 2025

经过一段时间的使用,发现之前 ytdl 这个东西属过度设计(想太多)。

ytdl 实际上只对 feeluown-ytmusic 有用,并且它的配置也很复杂,不如直接把这坨逻辑移到 ytmusic 中去实现。所以先默认关闭这个功能。

@coveralls
Copy link

coveralls commented Jan 31, 2025

Pull Request Test Coverage Report for Build 13068289375

Details

  • 1 of 2 (50.0%) changed or added relevant lines in 2 files are covered.
  • 9 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.05%) to 56.414%

Changes Missing Coverage Covered Lines Changed/Added Lines %
feeluown/app/app.py 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
feeluown/library/library.py 2 63.93%
feeluown/app/app.py 3 55.85%
feeluown/library/ytdl.py 4 13.75%
Totals Coverage Status
Change from base Build 13067962644: -0.05%
Covered Lines: 10018
Relevant Lines: 17758

💛 - Coveralls

@cosven cosven merged commit cd4404c into feeluown:master Jan 31, 2025
5 of 8 checks passed
@cosven cosven deleted the disable-ytdl branch January 31, 2025 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants