Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cmds refactor #382

Merged
merged 2 commits into from
Jul 2, 2020
Merged

Cmds refactor #382

merged 2 commits into from
Jul 2, 2020

Conversation

cosven
Copy link
Member

@cosven cosven commented Jul 2, 2020 •
edited
Loading

通过这个 PR #380 ，发现以前设计的一些不科学的地方

  1. 处理 CmdException，而不是简单的抛出 internal server error
  2. 给 show 命令添加一些单测
  3. 去除一些重复代码

@coveralls
Copy link

coveralls commented Jul 2, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.6%) to 34.434% when pulling d5c2754 on cmds-refactor into 66f17fd on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.6%) to 34.445% when pulling d5c2754 on cmds-refactor into 66f17fd on master.

@cosven cosven merged commit a6bdf34 into master Jul 2, 2020
@cosven cosven deleted the cmds-refactor branch July 3, 2020 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cosven @coveralls