install_pom.py: interpolate properties in current artifactId, groupId and version + add some tests #98
Conversation
Codecov Report
@@ Coverage Diff @@
## master #98 +/- ##
==========================================
+ Coverage 90.96% 91.00% +0.03%
==========================================
Files 45 45
Lines 3397 3400 +3
==========================================
+ Hits 3090 3094 +4
+ Misses 307 306 -1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Not sure where the codecov misses come from since I added two tests. Especially them being in files I did not touch. But... |
OK, now I understand, it is from my reproducible build changes from some time ago, not from this PR. |
|
Ping? |
|
ping |
|
Ping on this one |
|
Thanks for the ping, I will review it soon |
| @@ -172,7 +172,11 @@ def append_if_missing(archive_name, file_name, file_contents): | |||
| archive = zipfile.ZipFile(archive_name, 'a') | |||
| try: | |||
| if file_name not in archive.namelist(): | |||
| archive.writestr(file_name, file_contents) | |||
| file_time = min(4354819199, | |||
| max(315532800, | |||
There was a problem hiding this comment.
I had to search what these constants are, so a comment would be good.
|
Looks good. |
Some artifacts have things like
<artifactId>whatever_${scala.binary.version}</artifactId>. The variable normally is defined either in the current pom or in one of its parents. When generating simplified (dependencies-only) pom, interpolate this kind of variables in the current artifact coordinates too.This would need to be done eventually for mvn_artifact.py too. I tried but did not try a simple elegant way to do it, since the gathering of dependencies happen when the metadata artifact is already intitialized. But eventually one could create a maven artifact from the uart string, interpolate and push the 3 fields back to the metadata artifact. Or create a setter for it in the class.