Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reenable gravatar fallback #209

Closed
wants to merge 4 commits into from
Closed

Reenable gravatar fallback #209

wants to merge 4 commits into from

Conversation

hroncok
Copy link

@hroncok hroncok commented Aug 30, 2013

Fixes issue #148

@ralphbean
Copy link
Contributor

@hroncok, have you tried giving this a run locally? It looks to me like the fallback from libravatar to gravatar is working, but the subsequent fallback from gravatar to the nice badger avatar we have doesn't seem to be working. :/

@hroncok
Copy link
Author

hroncok commented Aug 30, 2013

I've just tried to do it manually and it doesn't work.

But I believe that's libravatar's bug.

Try this:

http://cdn.libravatar.org/avatar/ad9dac8d82ca10bd8b5b54dd06d333e9?d=https%3A%2F%2Fsecure.gravatar.com%2Favatar%2F0cc175b9c0f1b6a831c399e269772661%3Fs%3D312%26d%3Dhttp%253A%252F%252Fwww.google.com&s=312

It should fail to:

https://secure.gravatar.com/avatar/0cc175b9c0f1b6a831c399e269772661?s=312&d=http%3A%2F%2Fwww.google.com

But instead, only this is kept:

https://secure.gravatar.com/avatar/0cc175b9c0f1b6a831c399e269772661?s=312

@ralphbean
Copy link
Contributor

Huh.. could you file a bug on https://www.libravatar.org/ and link to it from here?

@hroncok
Copy link
Author

hroncok commented Aug 30, 2013

Here we go https://bugs.launchpad.net/libravatar/+bug/1219117

@ralphbean
Copy link
Contributor

Thanks, @hroncok!

@dtgay
Copy link
Contributor

dtgay commented Oct 27, 2013

So, what of the only comment? https://bugs.launchpad.net/libravatar/+bug/1219117/comments/1

@hroncok
Copy link
Author

hroncok commented Oct 28, 2013

Let's see.

@dtgay
Copy link
Contributor

dtgay commented Apr 21, 2014

Is this pull request dead?

@hroncok
Copy link
Author

hroncok commented Apr 21, 2014

It is blocked by libravatar bug.

@ralphbean ralphbean mentioned this pull request May 8, 2014
Merged
ralphbean added a commit to fedora-infra/supybot-fedora that referenced this pull request Jul 19, 2014
@ralphbean
Add a new command to list GH pull requests.
3fa47f0 
The command looks like this:

```
threebean │ .pulls
   zodbot │ threebean: (pulls <username/repo>) -- List the pending pull requests on a github repo.
threebean │ .pulls fedora-infra
   zodbot │ threebean: Must be GitHub repo of the format <username/repo>
threebean │ .pulls fedora-infra/tahrir
   zodbot │ threebean: @hroncok's "Reenable gravatar fallback" fedora-infra/tahrir#209
threebean │ .pulls fedora-watwat/tahrir
   zodbot │ threebean: No such GitHub repository 'fedora-watwat/tahrir'
threebean │ .pulls kennethreitz/requests
   zodbot │ threebean: @dpursehouse's "Linkify Github usernames in authors list" https://github.com/kennethreitz/requests/pull/2140
   zodbot │ threebean: @jamielennox's "Apply environment features to prepared requests" https://github.com/kennethreitz/requests/pull/2129
   zodbot │ threebean: @alekstorm's "Create Request.links_multi and utils function for properly parsing Link headers" https://github.com/kennethreitz/requests/pull/1980
   zodbot │ threebean: @kevinburke's "Connect timeout" https://github.com/kennethreitz/requests/pull/1801
```

It requires that we add an ``github.oauth_token`` to the zodbot config which we
can get from https://github.com/settings/tokens/new
@pypingou
Copy link
Member

There has been a little more activity on the bug (on launchpad) but that starts to be a while ago, should we ping again?

@hroncok
Copy link
Author

hroncok commented Aug 18, 2014

Bumped.

@ralphbean
Copy link
Contributor

We're still blocking on upstream here.

I'm going to close this pull request, only because it clutters a pull request queue that we want to try and keep clean. The code will still be around in @hroncok's branch and we can look forwards to re-opening it when we get progress on the libravatar side of things.

@ralphbean ralphbean closed this May 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hroncok @ralphbean @dtgay @pypingou