Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retire the vast majority of code #218

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

puiterwijk
Copy link
Contributor

This drops the code for the FAS auth modules for:

  • TurboGears1
  • TurboGears2
  • Django

All applications should have moved over to OpenID (Connect) by now.

This drops the FAS client, FAS is going away for Fedora rather soon.

This drops the OpenID Base clients: for API authentication, applications
need to switch to OpenID Connect.
At ths moment, Bodhi is the one client I am aware of that uses this,
and it will be moved to OIDC soon.

Signed-off-by: Patrick Uiterwijk [email protected]

@puiterwijk
Copy link
Contributor Author

My idea is to wait for FAS retirement to be imminent and Bodhi have moved to OIDC before releasing a version with this patch merged.

@pypingou
Copy link
Member

pypingou commented Nov 5, 2018

I'd keep around the OpenID base client as the FAS clients for now.
Dropping TG1, TG2 and Django, def +1

Basically, I'd say baby steps :)

It would be easier to do backports/fixes if the set of changes is lower, we can always open a new PR dropping these other files when the time to make that release comes

@blaisep
Copy link

blaisep commented Nov 7, 2018

Hi @puiterwijk I just asked @ralphbean if I should take care of issue 186
Maybe I should hold off until after this PR gets merged?

@Conan-Kudo
Copy link

Where are we for this patch? Having all this code dropped would make it much easier to package for Mageia and openSUSE...

This drops the code for the FAS auth modules for:
- TurboGears1
- TurboGears2
- Django

All applications should have moved over to OpenID (Connect) by now.

This drops the FAS client, FAS is going away for Fedora rather soon.

This drops the OpenID Base clients: for API authentication, applications
need to switch to OpenID Connect.
At ths moment, Bodhi is the one client I am aware of that uses this,
and it will be moved to OIDC soon.

Signed-off-by: Patrick Uiterwijk <[email protected]>
@hroncok
Copy link
Contributor

hroncok commented May 9, 2020

The current Fedora bodhi package uses fedora/client/openidbaseclient.py (at least in tests).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants