Fixes #455 - Added documentation for modifying message replay mechanism #492
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #492 +/- ##
==========================================
+ Coverage 60.06% 60.17% +0.1%
==========================================
Files 30 29 -1
Lines 1753 1750 -3
Branches 272 272
==========================================
Hits 1053 1053
+ Misses 623 620 -3
Partials 77 77Continue to review full report at Codecov.
|
doc/deployment.rst
Outdated
| messages, and store them all in the db. | ||
|
|
||
| :: | ||
| messages, and store them all in the db.:: |
There was a problem hiding this comment.
The changes in this file aren't related to the rest of the commit and don't seem necessary to me. Please don't include them in this commit. Thanks!
doc/subscribing.rst
Outdated
| missed from the datagrepper service. To disable this functionality: | ||
|
|
||
| #. Stop fedmsg-hub | ||
| #. Remove the file at on disk at ``/var/run/fedmsg/status/fedmsg-hub/*`` |
There was a problem hiding this comment.
This should be "Remove the file on disk at" rather than "Remove the file at on disk at"
… develop Merging changes with the current branch
|
@jeremycline Thanks for the review! I have made the necessary changes. I think this should be fine now. Please let me know if there are any issues. Thanks again! |
|
There seems to be a merge commit in there, maybe try using git rebase ? |
|
the merge commit is there because developer didn't create feature branch, thus this PR is linked to his |
|
i think it's simpler for maintainers to cherry pick and fixup the commit and be done with it. |
|
@jeremycline @glensc @pypingou Do I need to rebase my changes on top of current develop branch? Or would it be easier to open a new PR? |
|
Rebasing and force-pushing to your fork should be straight forward, but the new PR road is always an option |
This reverts commit 2a6148a. Since the CLI is not currently hooked up to anything, revert this commit before releasing v1.1.0. Signed-off-by: Jeremy Cline <[email protected]>
Signed-off-by: Jeremy Cline <[email protected]>
With the recent change to how CA certificates are loaded, just use the path to certificate. Signed-off-by: Jeremy Cline <[email protected]>
* fix: Use int validator for ca and crl cache expiry * fix: Give expiry keys sane defaults * test: Update expiry defaults * fix: Update relay_inbound references to use str * fix: Set crl_cache_expiry to a better default
In a non-zeromq case, it matters what the return value of _consume is. (It is a boolean, indicating if the message was successfully handled or not). This, in turn, gets used to figure out whether or not to send an ACK back to the broker. Here, the return values were being swallowed and turned into `None` values.
Signed-off-by: Jeremy Cline <[email protected]>
Signed-off-by: Jeremy Cline <[email protected]>
This will make python 3.6+ happier and stop sending DeprecationWarning Signed-off-by: Pierre-Yves Chibon <[email protected]>
This moves the documentation for each configuration value into the module docblock and alters the Sphinx auto-generated documentation to include the module-level documentation in the user-facing configuration page. The configuration API docs used to be the place where configuration load order was documented and users weren't finding it. The documentation itself is not changed. Fixes #505 Signed-off-by: Jeremy Cline <[email protected]>
Fixes #511 Signed-off-by: Jeremy Cline <[email protected]>
|
I did a git rebase and then pushed the fork on top. Hope this is alright. |
Added the documentation for changing replay mechanism in subscribing.rst