chore: Making embedding optional in retrieve_online_documents #5104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
franciscojavierarceo
requested review from
ejscribner,
tokoko and
redhatHameed
dmartinol
reviewed
Feb 27, 2025
sdk/python/feast/feature_store.py
Outdated
| @@ -1876,15 +1876,14 @@ def retrieve_online_documents_v2( | |||
| features: The list of features that should be retrieved from the online document store. These features can be | |||
| specified either as a list of string document feature references or as a feature service. String feature | |||
| references must have format "feature_view:feature", e.g, "document_fv:document_embeddings". | |||
| query: The query to retrieve the closest document features for. | |||
| query: The query to retrieve the closest document features for (optional) | |||
There was a problem hiding this comment.
Probably it's The embedded query rather than The query
There was a problem hiding this comment.
Also missed to doc the query_string param
There was a problem hiding this comment.
Good catch!
Signed-off-by: Francisco Javier Arceo <[email protected]>
|
Actually prowl doesn't work, do you mind clicking the approval? |
dmartinol
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
chore: Making embedding optional in retrieve_online_documents
Which issue(s) this PR fixes:
Misc