feat: Set value_type of entity directly in from_proto #5092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hkuepers <[email protected]>
nanohanno
force-pushed
the
feature/entity_type_from_proto
branch
from
632312c to
fb988ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In the last release a deprecation warning was added to
Entityif thevalue_typeisNone. Currently, thefrom_protomethod creates anEntityobject first withoutvalue_typeand sets it afterwards. Therefore, for each creation a Warning log is issued.This change moves the
value_typeinto the creator ofEntityin thefrom_protomethod.Which issue(s) this PR fixes:
Misc