-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Feast Operator RBAC example with Kubernetes Authentication … #5077
base: master
Are you sure you want to change the base?
Conversation
c022e37
to
8487ac3
Compare
@tchughesiv @franciscojavierarceo @dmartinol when you get a chance, could you please provide review/feedback on this PR? Thanks! |
2bb0cd0
to
5f02b7b
Compare
@redhatHameed one thing that's not obvious to me is how the test.py script makes use of the service account that is being used to connect to the feature store. I'm assuming it's automatically using some environment variable somewhere or something like that, but I'm not sure. Can we document that so it's more explicit? I expect users will want to be able to connect to a feature store instance from a script that isn't running inside of a kubernetes pod, and I'm assuming doing so would require them to specify the token somewhere, so we should make it clear how they can do so. |
@accorvin Right, it's getting directly from the pod location.
That's also possible, we can use environment variable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Install the Feast Operator section has quay image path, should it be dockerhub for now ? Also, quay.io/feastdev-ci
or quay.io/feastdev
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ntkathole Thanks right, this will be updated with quay once this PR merged
dfdc884
to
4a06332
Compare
@accorvin can you take another look of this PR, I have updated the notebook to use local client instead of the pod. Thanks |
…type. Signed-off-by: Abdul Hameed <[email protected]>
4a06332
to
e340a0d
Compare
What this PR does / why we need it:
Adding Feast Operator RBAC example with Kubernetes Authentication
Which issue(s) this PR fixes:
Misc