fix: Identify s3/remote uri path correctly #5076
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is the fix to correctly identify the file path as relative or absolute or remote path using urllib urlparse, which checks both scheme and netloc, ensuring it's a remote URI.
This seems the regression introduced in #4624
Input cases :
Input URI -> Recognized As -> Behavior
config.repo_path
Which issue(s) this PR fixes:
Fixes #4873 #4753 #4993