Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Identify s3/remote uri path correctly #5076

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

ntkathole
Copy link
Contributor

What this PR does / why we need it:

This is the fix to correctly identify the file path as relative or absolute or remote path using urllib urlparse, which checks both scheme and netloc, ensuring it's a remote URI.

This seems the regression introduced in #4624

Input cases :

Input URI -> Recognized As -> Behavior

  • s3://bucket/data.parquet -> Remote -> Uses as-is
  • /absolute/path/file.parquet -> Local -> Resolves normally
  • relative/path/file.parquet -> Local -> Resolves against config.repo_path
  • C:/path/to/file.parquet (Windows) -> Local -> Resolves correctly

Which issue(s) this PR fixes:

Fixes #4873 #4753 #4993

@ntkathole ntkathole requested a review from a team as a code owner February 20, 2025 16:23
Copy link
Member

@franciscojavierarceo franciscojavierarceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @ntkathole !!! Any chance you could add some unit tests so we can make sure this issue doesn't slip through going forward?

@ntkathole ntkathole force-pushed the fix_remote_uri branch 3 times, most recently from 2bc78f9 to ac389ab Compare February 22, 2025 09:07
@ntkathole
Copy link
Contributor Author

add some unit tests so we can make sure this issue doesn't slip through going forward?

Done!

Copy link
Member

@franciscojavierarceo franciscojavierarceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one last nit, otherwise lgtm! approving in advance

@franciscojavierarceo franciscojavierarceo merged commit 93becff into feast-dev:master Feb 24, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect path in file data source to s3 bucket
2 participants