test: Added upgrade tests

[tmihalac]

Added feast go operator upgrade tests

What this PR does / why we need it:

Tests backward compatibility of the CR

There are 2 new test suites with new make targets:
test-previous-version - Deploys the previous version operator and feast server, applies the previous version CRs and runs the e2e test
test-upgrade - Deploys the previous version operator and feast server, applies the current CRs and runs the e2e test

Those tests are run in the integration test github action right after the make test-e2e target

[tmihalac]

Please have a look I've split the pervious version test and the upgrade version test into 2 test suites, so I might call them from the OpenshiftCI @tchughesiv @lokeshrangineni @redhatHameed

[redhatHameed]

just want make sure this is correct, we have online store/server default now. so need registry here instead of online. WDYT ?
cc @tchughesiv

[tchughesiv]

or, just add feastResourceName + "-registry",

[tmihalac]

just want make sure this is correct, we have online store/server default now. so need registry here instead of online. WDYT ? cc @tchughesiv

@redhatHameed @tchughesiv I used the old e2e tests without changing them and in them there is special care of registry, i didn't want to mix updating/fixing e2e tests following latests changes with doing an upgrade test, I think it should be a different task

[redhatHameed]

maybe try to change feastResourceName + "-online" -> feastResourceName + "-registry" and see where it breaks ? if this required more works then we can open a separate PR for this.

[tmihalac]

maybe try to change feastResourceName + "-online" -> feastResourceName + "-registry" and see where it breaks ? if this required more works then we can open a separate PR for this.

It causes the tests to fail, I think it should be in a different task

[tchughesiv]

i think we need a different method maybe? one that checks for remote registry and one that checks for local registry service. when remote registry is configured, a svc won't exist for it

[tmihalac]

i think we need a different method maybe? one that checks for remote registry and one that checks for local registry service. when remote registry is configured, a svc won't exist for it

Do you think it should be fixed as part of the upgrade tests ? IMO it should be a separate task - "revise existing e2e test and enhance them"

[tchughesiv]

+1

[tmihalac]

Opened an new issues to track this #5091

[redhatHameed]

@tmihalac few minor questions

1. Are the upgrade tests set to run during the Feast release process, or every pull request?
2. What will happened if test fails will this block releases ?

[tmihalac]

@tmihalac few minor questions

1. Are the upgrade tests set to run during the Feast release process, or every pull request?
2. What will happened if test fails will this block releases ?

@redhatHameed I've added them to the e2e github action which runs on:

  push:
    branches:
      - main
  pull_request:
    types:
      - opened
      - synchronize
      - labeled```