feat: Add Couchbase Columnar as an Offline Store #5025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejscribner
force-pushed
the
couchbase-offline-store
branch
6 times, most recently
from
35e23e9 to
64f2616
Compare
ejscribner
force-pushed
the
couchbase-offline-store
branch
from
64f2616 to
655f2d1
Compare
ejscribner
force-pushed
the
couchbase-offline-store
branch
2 times, most recently
from
6bdb721 to
583defd
Compare
ntkathole
reviewed
Feb 26, 2025
| COUCHBASE_REQUIRED = ["couchbase==4.3.2"] | ||
| COUCHBASE_REQUIRED = [ | ||
| "couchbase==4.3.2", | ||
| "couchbase-columnar==1.0.0" |
There was a problem hiding this comment.
Add this in https://github.com/feast-dev/feast/blob/master/pyproject.toml#L58 as well
There was a problem hiding this comment.
Thanks, added: 645467b
ejscribner
force-pushed
the
couchbase-offline-store
branch
from
dc1a10b to
d23a582
Compare
Signed-off-by: Elliot Scribner <[email protected]>
Signed-off-by: Elliot Scribner <[email protected]>
Signed-off-by: Elliot Scribner <[email protected]>
Signed-off-by: Elliot Scribner <[email protected]>
Signed-off-by: Elliot Scribner <[email protected]>
Signed-off-by: Elliot Scribner <[email protected]>
Signed-off-by: Elliot Scribner <[email protected]>
Signed-off-by: Elliot Scribner <[email protected]>
Signed-off-by: Elliot Scribner <[email protected]>
Signed-off-by: Elliot Scribner <[email protected]>
Signed-off-by: Elliot Scribner <[email protected]>
Signed-off-by: Elliot Scribner <[email protected]>
Signed-off-by: Elliot Scribner <[email protected]>
Signed-off-by: Elliot Scribner <[email protected]>
Signed-off-by: Elliot Scribner <[email protected]>
Signed-off-by: Elliot Scribner <[email protected]>
Signed-off-by: Elliot Scribner <[email protected]>
Signed-off-by: Elliot Scribner <[email protected]>
Signed-off-by: Elliot Scribner <[email protected]>
Signed-off-by: Elliot Scribner <[email protected]>
Signed-off-by: Elliot Scribner <[email protected]>
Signed-off-by: Elliot Scribner <[email protected]>
ejscribner
force-pushed
the
couchbase-offline-store
branch
from
645467b to
4df968b
Compare
franciscojavierarceo
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
N/A
Misc