feat: Updated feast Go operator db stores

infra/feast-operator/api/v1alpha1/featurestore_types.go

@@ -108,9 +108,11 @@ var ValidOfflineStoreFilePersistenceTypes = []string{
 // OfflineStoreDBStorePersistence configures the DB store persistence for the offline store service
 type OfflineStoreDBStorePersistence struct {
 	// +kubebuilder:validation:Enum=snowflake.offline;bigquery;redshift;spark;postgres;feast_trino.trino.TrinoOfflineStore;redis
-	Type          string                      `json:"type"`
-	SecretRef     corev1.LocalObjectReference `json:"secretRef"`
-	SecretKeyName string                      `json:"secretKeyName,omitempty"`
+	Type string `json:"type"`
+	// Data store parameters should be placed as-is from the "feature_store.yaml" under the secret key. "registry_type" & "type" fields should be removed.
+	SecretRef corev1.LocalObjectReference `json:"secretRef"`
+	// By default, the selected store "type" is used as the SecretKeyName
+	SecretKeyName string `json:"secretKeyName,omitempty"`
 }
 
 var ValidOfflineStoreDBStorePersistenceTypes = []string{
@@ -149,9 +151,11 @@ type OnlineStoreFilePersistence struct {
 // OnlineStoreDBStorePersistence configures the DB store persistence for the offline store service
 type OnlineStoreDBStorePersistence struct {
 	// +kubebuilder:validation:Enum=snowflake.online;redis;ikv;datastore;dynamodb;bigtable;postgres;cassandra;mysql;hazelcast;singlestore
-	Type          string                      `json:"type"`
-	SecretRef     corev1.LocalObjectReference `json:"secretRef"`
-	SecretKeyName string                      `json:"secretKeyName,omitempty"`
+	Type string `json:"type"`
+	// Data store parameters should be placed as-is from the "feature_store.yaml" under the secret key. "registry_type" & "type" fields should be removed.
+	SecretRef corev1.LocalObjectReference `json:"secretRef"`
+	// By default, the selected store "type" is used as the SecretKeyName
+	SecretKeyName string `json:"secretKeyName,omitempty"`
 }
 
 var ValidOnlineStoreDBStorePersistenceTypes = []string{
@@ -196,9 +200,11 @@ type RegistryFilePersistence struct {
 // RegistryDBStorePersistence configures the DB store persistence for the registry service
 type RegistryDBStorePersistence struct {
 	// +kubebuilder:validation:Enum=sql;snowflake.registry
-	Type          string                      `json:"type"`
-	SecretRef     corev1.LocalObjectReference `json:"secretRef"`
-	SecretKeyName string                      `json:"secretKeyName,omitempty"`
+	Type string `json:"type"`
+	// Data store parameters should be placed as-is from the "feature_store.yaml" under the secret key. "registry_type" & "type" fields should be removed.
+	SecretRef corev1.LocalObjectReference `json:"secretRef"`
+	// By default, the selected store "type" is used as the SecretKeyName
+	SecretKeyName string `json:"secretKeyName,omitempty"`
 }
 
 var ValidRegistryDBStorePersistenceTypes = []string{
@@ -280,8 +286,10 @@ type OptionalConfigs struct {
 }
 
 // AuthzConfig defines the authorization settings for the deployed Feast services.
+// +kubebuilder:validation:XValidation:rule="[has(self.kubernetes), has(self.oidc)].exists_one(c, c)",message="One selection required between kubernetes or oidc."
 type AuthzConfig struct {
 	KubernetesAuthz *KubernetesAuthz `json:"kubernetes,omitempty"`
+	OidcAuthz       *OidcAuthz       `json:"oidc,omitempty"`
 }
 
 // KubernetesAuthz provides a way to define the authorization settings using Kubernetes RBAC resources.
@@ -296,6 +304,12 @@ type KubernetesAuthz struct {
 	Roles []string `json:"roles,omitempty"`
 }
 
+// OidcAuthz defines the authorization settings for deployments using an Open ID Connect identity provider.
+// https://auth0.com/docs/authenticate/protocols/openid-connect-protocol
+type OidcAuthz struct {
+	SecretRef corev1.LocalObjectReference `json:"secretRef"`
+}
+
 // TlsConfigs configures server TLS for a feast service. in an openshift cluster, this is configured by default using service serving certificates.
 // +kubebuilder:validation:XValidation:rule="(!has(self.disable) || !self.disable) ? has(self.secretRef) : true",message="`secretRef` required if `disable` is false."
 type TlsConfigs struct {

infra/feast-operator/config/crd/bases/feast.dev_featurestores.yaml

@@ -69,7 +69,31 @@ spec:
                           type: string
                         type: array
                     type: object
+                  oidc:
+                    description: |-
+                      OidcAuthz defines the authorization settings for deployments using an Open ID Connect identity provider.
+                      https://auth0.com/docs/authenticate/protocols/openid-connect-protocol
+                    properties:
+                      secretRef:
+                        description: |-
+                          LocalObjectReference contains enough information to let you locate the
+                          referenced object inside the same namespace.
+                        properties:
+                          name:
+                            description: |-
+                              Name of the referent.
+                              More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names
+                              TODO: Add other useful fields. apiVersion, kind, uid?
+                            type: string
+                        type: object
+                        x-kubernetes-map-type: atomic
+                    required:
+                    - secretRef
+                    type: object
                 type: object
+                x-kubernetes-validations:
+                - message: One selection required between kubernetes or oidc.
+                  rule: '[has(self.kubernetes), has(self.oidc)].exists_one(c, c)'
               feastProject:
                 description: FeastProject is the Feast project id. This can be any
                   alphanumeric string with underscores, but it cannot start with an
@@ -297,11 +321,13 @@ spec:
                               the DB store persistence for the offline store service
                             properties:
                               secretKeyName:
+                                description: By default, the selected store "type"
+                                  is used as the SecretKeyName
                                 type: string
                               secretRef:
-                                description: |-
-                                  LocalObjectReference contains enough information to let you locate the
-                                  referenced object inside the same namespace.
+                                description: Data store parameters should be placed
+                                  as-is from the "feature_store.yaml" under the secret
+                                  key. "registry_type" & "type" fields should be removed.
                                 properties:
                                   name:
                                     description: |-
@@ -652,11 +678,13 @@ spec:
                               the DB store persistence for the offline store service
                             properties:
                               secretKeyName:
+                                description: By default, the selected store "type"
+                                  is used as the SecretKeyName
                                 type: string
                               secretRef:
-                                description: |-
-                                  LocalObjectReference contains enough information to let you locate the
-                                  referenced object inside the same namespace.
+                                description: Data store parameters should be placed
+                                  as-is from the "feature_store.yaml" under the secret
+                                  key. "registry_type" & "type" fields should be removed.
                                 properties:
                                   name:
                                     description: |-
@@ -1025,11 +1053,14 @@ spec:
                                   the DB store persistence for the registry service
                                 properties:
                                   secretKeyName:
+                                    description: By default, the selected store "type"
+                                      is used as the SecretKeyName
                                     type: string
                                   secretRef:
-                                    description: |-
-                                      LocalObjectReference contains enough information to let you locate the
-                                      referenced object inside the same namespace.
+                                    description: Data store parameters should be placed
+                                      as-is from the "feature_store.yaml" under the
+                                      secret key. "registry_type" & "type" fields
+                                      should be removed.
                                     properties:
                                       name:
                                         description: |-
@@ -1238,7 +1269,32 @@ spec:
                               type: string
                             type: array
                         type: object
+                      oidc:
+                        description: |-
+                          OidcAuthz defines the authorization settings for deployments using an Open ID Connect identity provider.
+                          https://auth0.com/docs/authenticate/protocols/openid-connect-protocol
+                        properties:
+                          secretRef:
+                            description: |-
+                              LocalObjectReference contains enough information to let you locate the
+                              referenced object inside the same namespace.
+                            properties:
+                              name:
+                                description: |-
+                                  Name of the referent.
+                                  More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names
+                                  TODO: Add other useful fields. apiVersion, kind, uid?
+                                type: string
+                            type: object
+                            x-kubernetes-map-type: atomic
+                        required:
+                        - secretRef
+                        type: object
                     type: object
+                    x-kubernetes-validations:
+                    - message: One selection required between kubernetes or oidc.
+                      rule: '[has(self.kubernetes), has(self.oidc)].exists_one(c,
+                        c)'
                   feastProject:
                     description: FeastProject is the Feast project id. This can be
                       any alphanumeric string with underscores, but it cannot start
@@ -1468,11 +1524,14 @@ spec:
                                   the DB store persistence for the offline store service
                                 properties:
                                   secretKeyName:
+                                    description: By default, the selected store "type"
+                                      is used as the SecretKeyName
                                     type: string
                                   secretRef:
-                                    description: |-
-                                      LocalObjectReference contains enough information to let you locate the
-                                      referenced object inside the same namespace.
+                                    description: Data store parameters should be placed
+                                      as-is from the "feature_store.yaml" under the
+                                      secret key. "registry_type" & "type" fields
+                                      should be removed.
                                     properties:
                                       name:
                                         description: |-
@@ -1829,11 +1888,14 @@ spec:
                                   the DB store persistence for the offline store service
                                 properties:
                                   secretKeyName:
+                                    description: By default, the selected store "type"
+                                      is used as the SecretKeyName
                                     type: string
                                   secretRef:
-                                    description: |-
-                                      LocalObjectReference contains enough information to let you locate the
-                                      referenced object inside the same namespace.
+                                    description: Data store parameters should be placed
+                                      as-is from the "feature_store.yaml" under the
+                                      secret key. "registry_type" & "type" fields
+                                      should be removed.
                                     properties:
                                       name:
                                         description: |-
@@ -2210,11 +2272,14 @@ spec:
                                       the DB store persistence for the registry service
                                     properties:
                                       secretKeyName:
+                                        description: By default, the selected store
+                                          "type" is used as the SecretKeyName
                                         type: string
                                       secretRef:
-                                        description: |-
-                                          LocalObjectReference contains enough information to let you locate the
-                                          referenced object inside the same namespace.
+                                        description: Data store parameters should
+                                          be placed as-is from the "feature_store.yaml"
+                                          under the secret key. "registry_type" &
+                                          "type" fields should be removed.
                                         properties:
                                           name:
                                             description: |-

infra/feast-operator/config/samples/v1alpha1_featurestore_db_persistence.yaml

@@ -11,5 +11,25 @@ spec:
         store:
           type: postgres
           secretRef:
-            name: my-secret
-          secretKeyName: mykey   # optional
+            name: postgres-secret
+          secretKeyName: postgres-secret-parameters   # optional
+    registry:
+      local:
+        persistence:
+          store:
+            type: sql
+            secretRef:
+              name: postgres-secret
+            secretKeyName: postgres-secret-parameters   # optional
+---
+apiVersion: v1
+kind: Secret
+metadata:
+  name: postgres-secret
+stringData:
+  postgres-secret-parameters: |
+    path: postgresql://postgres:[email protected]:55001/feast
+    cache_ttl_seconds: 60
+    sqlalchemy_config_kwargs:
+      echo: false
+      pool_pre_ping: true

infra/feast-operator/config/samples/v1alpha1_featurestore_oidc_auth.yaml

@@ -0,0 +1,35 @@
+apiVersion: feast.dev/v1alpha1
+kind: FeatureStore
+metadata:
+  name: sample-oidc-auth
+spec:
+  feastProject: my_project
+  services:
+    onlineStore:
+      persistence:
+        file:
+          path: /data/online_store.db
+    offlineStore:
+      persistence:
+        file:
+          type: dask
+    registry:
+      local:
+        persistence:
+          file:
+            path: /data/registry.db
+  authz:
+    oidc:
+      secretRef:
+        name: oidc-secret
+---
+kind: Secret
+apiVersion: v1
+metadata:
+  name: oidc-secret
+stringData:
+  client_id: client_id
+  auth_discovery_url: auth_discovery_url
+  client_secret: client_secret
+  username: username
+  password: password