Skip to content

Commit

Permalink
removed nameLabelKey, using serices.NameLabelKey
Browse files Browse the repository at this point in the history
Signed-off-by: Daniele Martinoli <[email protected]>
  • Loading branch information
dmartinol committed Nov 25, 2024
1 parent 556d80b commit 7484764
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
4 changes: 2 additions & 2 deletions infra/feast-operator/internal/controller/auth/auth.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import (
"sigs.k8s.io/controller-runtime/pkg/log"
)

// Deploy the feast services
// Deploy the feast authorization
func (auth *FeastAuth) Deploy() error {
authConfig := auth.Handler.FeatureStore.Status.Applied.AuthConfig
if authConfig != nil {
Expand Down Expand Up @@ -193,7 +193,7 @@ func (auth *FeastAuth) setAuthRole(role *rbacv1.Role) error {

func (auth *FeastAuth) getLabels() map[string]string {
return map[string]string{
nameLabelKey: auth.Handler.FeatureStore.Name,
services.NameLabelKey: auth.Handler.FeatureStore.Name,
}
}

Expand Down
2 changes: 0 additions & 2 deletions infra/feast-operator/internal/controller/auth/auth_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@ type FeastAuth struct {
}

var (
nameLabelKey = feastdevv1alpha1.GroupVersion.Group + "/name"

feastKubernetesAuthConditions = map[metav1.ConditionStatus]metav1.Condition{
metav1.ConditionTrue: {
Type: feastdevv1alpha1.KubernetesAuthReadyType,
Expand Down

0 comments on commit 7484764

Please sign in to comment.