Initial implementation for streams with http2 module #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptpaterson
requested review from
erickpintor,
marrony,
pnwpedro,
fauna-chase and
cleve-fauna
ptpaterson
force-pushed
the
streaming-node
branch
from
d8ba5cb to
3451d3e
Compare
ptpaterson
commented
Mar 8, 2024
ptpaterson
force-pushed
the
streaming-node
branch
from
3258c1c to
536f3cf
Compare
ptpaterson
force-pushed
the
streaming-node
branch
from
536f3cf to
1f88f70
Compare
ptpaterson
added a commit
that referenced
this pull request
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s): FE-4969
Problem
The first iteration of v10 streaming did provide a default implementation for Node.js
Solution
Add a streaming implementation to the
NodeHTTP2ClientclassResult
V10 streams can be used in Node.js by default
Out of scope
There are changes to the error shape on the core side that might not initially be incorporated here.
Testing
I am running tests with a Node.js script running locally on my machine.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.