don't defer closing the response writer #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closing the response writer signifies to the Compute runtime that the response has been successfully completed, so we shouldn't defer it in case the handler panics. In TinyGo, defers aren't run after panic so this wasn't executed. In Go, defers are run. The result of this was that if a handler panicked before sending a response, it would send an empty 200 OK response in Go but a 500 Internal Server Error in TinyGo. Fixes #98.
Integralist
approved these changes
Jan 4, 2024
|
v1.2.1 was released today. https://github.com/fastly/compute-sdk-go/releases/tag/v1.2.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing the response writer signifies to the Compute runtime that the
response has been successfully completed, so we shouldn't defer it in
case the handler panics.
In TinyGo, defers aren't run after panic so this wasn't executed. In
Go, defers are run. The result of this was that if a handler panicked
before sending a response, it would send an empty 200 OK response in Go
but a 500 Internal Server Error in TinyGo.
Fixes #98.