abi/fastly: correct max value length and use scratch buffer in Dictionary#GetBytes #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpereira
reviewed
Jun 18, 2024
lpereira
approved these changes
Jun 18, 2024
|
Nevermind this. I was thinking about the names, not the keys (or values). |
cee-dub
force-pushed
the
cw/config-store-size
branch
2 times, most recently
from
b39e673 to
200090c
Compare
Takes advantage of wasm being single-threaded, and the internal/external boundary to reduce allocations to the minimum necessary to copy bytes from the hostcall to the guest. When the bytes are returned to the caller, they're either copied to a fresh `[]byte` or returned as a `string` (implicit copy).
cee-dub
force-pushed
the
cw/config-store-size
branch
from
0a80e65 to
30ccd01
Compare
cee-dub
force-pushed
the
cw/config-store-size
branch
from
642eb27 to
bdfaf9f
Compare
lpereira
reviewed
Jun 21, 2024
dgryski
reviewed
Jun 21, 2024
cee-dub
requested review from
lpereira and
dgryski
and removed request for
tomchappell
cee-dub
changed the title
cee-dub
changed the title
dgryski
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates work from #117 to handle documented limits for config stores correctly.
In #117 a heuristic was applied to buffers to start small, and increase to a size above the documented limit of "8000 characters." Those characters, however, are UTF-8 encoded, and thus could be comprised of as many as 8000 * 3 bytes. This PR correctly adjusts up to that maximum limit, with an intermediate step for up to 8000 UTF-8 encoded ASCII-range characters, which need 8000 bytes.
It also introduces a scratch space buffer for copies across the host/guest boundary and passes up copies of returned values from the config store.