Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stubs for new "busy handle" APIs for the core cache #373

Merged
merged 2 commits into from
May 23, 2024

Conversation

aturon
Copy link
Contributor

@aturon aturon commented May 23, 2024

As with existing caching APIs, these are just stubs for now, needed to support new SDK releases.

@aturon aturon requested a review from elliottt May 23, 2024 18:35
elliottt
elliottt previously approved these changes May 23, 2024
Copy link
Contributor

@elliottt elliottt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! I made one suggestion to update a comment to use the wit name of the flag instead of the witx one.

lib/wit/deps/fastly/compute.wit Outdated Show resolved Hide resolved
@aturon aturon merged commit 33dab4a into main May 23, 2024
7 checks passed
@aturon aturon deleted the aturon/stub-busy-handle branch May 23, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants