Update for Fastify v5 #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
requested changes
Apr 16, 2024
|
Ok What about moving to tap, from tape? |
|
@Fdawgs can you add to the workflows a passable option that corresponds to sth like “also test on” to add additional node versions? |
nope, tape works great across the supported version of Node.js |
Kind of goes against the point of the workflows, which was to create a standardised workflow that had minimal config, so that all plugins had to adhere to the same testing. |
|
This is not a plugin. |
Fdawgs
approved these changes
Apr 17, 2024
|
this does not need to go to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.