perf(lib): replace redundant reduce call on array #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsumners
reviewed
Jan 6, 2025
jsumners
approved these changes
Jan 8, 2025
Fdawgs
changed the title
gurgunday
reviewed
Jan 8, 2025
Co-authored-by: Gürgün Dayıoğlu <[email protected]> Signed-off-by: Frazer Smith <[email protected]>
Fdawgs
changed the title
jsumners
approved these changes
Jan 8, 2025
gurgunday
approved these changes
Jan 8, 2025
|
CI seems failing |
Workflows are still annoyingly using 22.12 rather than 22.13, which fixed the Windows issue that this is flagging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Array of colors does not need to be reduced as the array returned by
Object.entries(colors)is suitably structured anyway!Benchmarks
Before:
formatMessageColorized x 3,222,129 ops/sec ±0.74% (191 runs sampled)After:
formatMessageColorized x 3,541,809 ops/sec ±0.56% (189 runs sampled)Checklist
npm run testandnpm run benchmarkand the Code of conduct