fix: restore express prototypes so injecting doesn't break http requests #333
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm attempting to port an internal express app test framework to use light-my-request because it hugely increases performance (thanks!), but some of the framework's plugins still need to make HTTP requests.
Currenlty the first
inject()
call will permenantly modify the app's request and response prototypes, making subsequent HTTP requests crash the server - this change fixes that by caching them and setting the back to the originals.Ta
Checklist
npm run test
andnpm run benchmark
and the Code of conduct