refactor(lib/request): remove unused params

[Fdawgs]

Not used at all within their respective functions.

Checklist

• run npm run test and npm run benchmark
• commit message and code follows the Developer's Certification of Origin
  and the Code of conduct

[mcollina]

historically, these impacted perf as it removed a C++ call in V8.

[Fdawgs]

historically, these impacted perf as it removed a C++ call in V8.

Thanks for the insight @mcollina, do you know if this is still a thing with Node >= 20?

[Uzlopak]

is there more information regarding this "hack"?

[mcollina]

https://v8.dev/blog/adaptor-frame

[mcollina]

do you know if this is still a thing with Node >= 20?

It shouldn't be, but it should be measured.

[Fdawgs]

Threw together a quick benchmark:

'use strict'

const Benchmark = require('benchmark')
const suite = new Benchmark.Suite()

function noParams () {
  return 'hello'
}

function unusedParams (_unused) {
  return 'hello'
}

suite.add('Unused Params Function', function () {
  unusedParams()
})
  .add('No Params Function', function () {
    noParams()
  })
  .on('cycle', function (event) {
    console.log(String(event.target))
  })
  .on('complete', function () {
    console.log('Fastest is ' + this.filter('fastest').map('name'))
  })
  .run()

Output (running on Intel i7-13650HX @4.9Ghz) with Node 20.18.1:

Unused Params Function x 1,710,143,718 ops/sec ±0.32% (94 runs sampled)
No Params Function x 1,721,140,393 ops/sec ±0.28% (95 runs sampled)
Fastest is No Params Function

[mcollina]

lgtm