Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix (types): changed document type to a discriminating union #807

Merged
merged 1 commit into from
Jul 23, 2024
Merged

fix (types): changed document type to a discriminating union #807

merged 1 commit into from
Jul 23, 2024

Conversation

Bram-dc
Copy link
Contributor

@Bram-dc Bram-dc commented Jul 15, 2024 •
edited
Loading

I changed the type of openapiObject and swaggerObject to be a discriminating union as it is used in the .js files.

Checklist

mcollina
mcollina approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit ce8c75a into fastify:master Jul 23, 2024
11 checks passed
mcollina pushed a commit that referenced this pull request Jul 23, 2024
@Bram-dc @mcollina
fix (types): changed document type to a discriminating union (#807)
409380c
@jlenon7 jlenon7 mentioned this pull request Aug 15, 2024
Merged
@WesleyR10 WesleyR10 mentioned this pull request Aug 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@gurgunday gurgunday gurgunday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bram-dc @mcollina @gurgunday