Resolved Cannot convert a BigInt value to a number (#723)

* Resolved Cannot convert a BigInt value to a number Signed-off-by: Camillo Positano <[email protected]> * added test for asNumber throwing exception Exception thrown was Cannot convert a BigInt value to a number. This test verifies that it can convert a big int Signed-off-by: Camillo Positano <[email protected]> --------- Signed-off-by: Camillo Positano <[email protected]>
fastify · Jun 19, 2024 · 85e1f07 · 85e1f07
1 parent cf5c0d0
commit 85e1f07
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/lib/serializer.js b/lib/serializer.js
@@ -41,7 +41,7 @@ module.exports = class Serializer {
 
   asNumber (i) {
     // fast cast to number
-    const num = +i
+    const num = Number(i)
     // check if number is NaN
     // eslint-disable-next-line no-self-compare
     if (num !== num) {

diff --git a/test/asNumber.test.js b/test/asNumber.test.js
@@ -0,0 +1,13 @@
+'use strict'
+
+const test = require('tap').test
+
+test('asNumber should convert BigInt', (t) => {
+  t.plan(1)
+  const Serializer = require('../lib/serializer')
+  const serializer = new Serializer()
+
+  const number = serializer.asNumber(11753021440n)
+
+  t.equal(number, '11753021440')
+})