types(DeepMergeAllFn): refine DeepMergeAllFn return type when handling lists with deep partial objects #64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue in the
DeepMergeAllFn
type where the returned type did not correctly match the type of the first object in scenarios where a list of objects was passed, and the subsequent objects were deep partial versions of the first.Problem
Previously, when DeepMergeAllFn was called with a list of objects, where all objects from the second onward were deep partial versions of the first object, the return type defaulted to DeepMergeAll<{}, T> instead of preserving the type of the first object. This led to incorrect typings and made the function’s behavior less predictable.
The screenshot below shows the error before the changes in this PR: the
deepmerge
function would return a partial object type.Checklist
npm run test
andnpm run benchmark
and the Code of conduct