Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dont use undocumented(?) internal _events attribute #146

Merged
merged 1 commit into from
Feb 28, 2024
Merged

fix: dont use undocumented(?) internal _events attribute #146

merged 1 commit into from
Feb 28, 2024

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Feb 28, 2024

@Uzlopak Uzlopak mentioned this pull request Feb 28, 2024
Open
@Uzlopak Uzlopak changed the title fix: dont use internal _events attribute fix: dont use undocumented(?) internal _events attribute Feb 28, 2024
gurgunday
gurgunday approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mcollina
mcollina approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 501f7d6 into master Feb 28, 2024
22 checks passed
@mcollina mcollina deleted the avoid-_event branch February 28, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gurgunday gurgunday gurgunday approved these changes

@mcollina mcollina mcollina approved these changes

@kibertoad kibertoad Awaiting requested review from kibertoad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Uzlopak @mcollina @gurgunday