Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extract create-promise #218

Merged
merged 3 commits into from
Jun 25, 2023
Merged

extract create-promise #218

merged 3 commits into from
Jun 25, 2023

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Jun 24, 2023 •
edited
Loading

based on #199

added unit tests and jsdoc

Checklist

@Uzlopak Uzlopak requested a review from climba03003 June 24, 2023 12:15
mcollina
mcollina requested changes Jun 25, 2023
View reviewed changes
lib/create-promise.js Outdated Show resolved Hide resolved
@Uzlopak
Copy link
Contributor Author

Uzlopak commented Jun 25, 2023 •
edited
Loading

I have a general question. Is it better to define them as null or is undefined sufficient?

@Uzlopak Uzlopak mentioned this pull request Jun 25, 2023
Merged
4 tasks
mcollina
mcollina approved these changes Jun 25, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 12cf911 into master Jun 25, 2023
@Uzlopak Uzlopak deleted the extract-create-promise branch June 25, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@climba03003 climba03003 Awaiting requested review from climba03003

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Uzlopak @mcollina