Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Editor Usability #162

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

superjkl
Copy link

Issues Fixed

  • When using autocorrect and pressing enter so the word is corrected instead of replacing the misspelled word with the correction we find the correction is just placed on the next line
    • I assume this happens because onValueChange does not execute after all changes are finished while outputTransformation happens after all changes to the text state
  • When editing a note the keyboard opens to cover the cursor. Instead the text will now scroll to show the cursor

New Behavior

When markup/html is disabled double tapping to edit will put the cursor where you tapped instead of at the end of the note. I don't know if this is useful for most users or if there should be a setting to toggle this behavior.

Tickets Addressed

#157
#158

… enter. Fix issue where cursor is hidden by keyboard. When markup/html is disabled double tapping to edit will put the cursor where you tapped.
@robin-paulson
Copy link

Fantastic, it'd be great to see if this fixes the problems I have too. Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants