Skip to content

Commit

Permalink
Release 3.5.1 (nf-core#1799)
Browse files Browse the repository at this point in the history
<!--
# nf-core/sarek pull request

Many thanks for contributing to nf-core/sarek!

Please fill in the appropriate checklist below (delete whatever is not
relevant).
These are the most common things requested on pull requests (PRs).

Remember that PRs should be made against the dev branch, unless you're
preparing a pipeline release.

Learn more about contributing:
[CONTRIBUTING.md](https://github.com/nf-core/sarek/tree/master/.github/CONTRIBUTING.md)
-->

## PR checklist

- [ ] This comment contains a description of changes (with reason).
- [ ] If you've fixed a bug or added code that should be tested, add
tests!
- [ ] If you've added a new tool - have you followed the pipeline
conventions in the [contribution
docs](https://github.com/nf-core/sarek/tree/master/.github/CONTRIBUTING.md)
- [ ] If necessary, also make a PR on the nf-core/sarek _branch_ on the
[nf-core/test-datasets](https://github.com/nf-core/test-datasets)
repository.
- [ ] Make sure your code lints (`nf-core pipelines lint`).
- [ ] Ensure the test suite passes (`nextflow run . -profile test,docker
--outdir <OUTDIR>`).
- [ ] Check for unexpected warnings in debug mode (`nextflow run .
-profile debug,test,docker --outdir <OUTDIR>`).
- [ ] Usage Documentation in `docs/usage.md` is updated.
- [ ] Output Documentation in `docs/output.md` is updated.
- [ ] `CHANGELOG.md` is updated.
- [ ] `README.md` is updated (including new tool citations and
authors/contributors).

---------

Co-authored-by: Friederike Hanssen <[email protected]>
Co-authored-by: Friederike Hanssen <[email protected]>
Co-authored-by: tdanhorn <[email protected]>
Co-authored-by: Thomas <[email protected]>
  • Loading branch information
5 people authored Feb 18, 2025
1 parent ae4dd11 commit 5fe5cdf
Show file tree
Hide file tree
Showing 26 changed files with 114 additions and 70 deletions.
27 changes: 18 additions & 9 deletions .github/workflows/cloudtest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -81,13 +81,24 @@ jobs:
if: github.repository == 'nf-core/sarek' && github.event.review.state == 'approved' && github.event.pull_request.base.ref == 'master' || github.event_name == 'workflow_dispatch'
runs-on: ubuntu-latest
steps:
- uses: octokit/[email protected]
- name: Get PR reviews
uses: octokit/[email protected]
if: github.event_name != 'workflow_dispatch'
id: check_approvals
continue-on-error: true
with:
route: GET /repos/${{ github.repository }}/pulls/${{ github.event.pull_request.number }}/reviews
route: GET /repos/${{ github.repository }}/pulls/${{ github.event.pull_request.number }}/reviews?per_page=100
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- id: test_variables

- name: Check for approvals
if: ${{ failure() && github.event_name != 'workflow_dispatch' }}
run: |
echo "No review approvals found. At least 2 approvals are required to run this action automatically."
exit 1
- name: Check for enough approvals (>=2)
id: test_variables
if: github.event_name != 'workflow_dispatch'
run: |
JSON_RESPONSE='${{ steps.check_approvals.outputs.data }}'
Expand All @@ -114,11 +125,9 @@ jobs:
}
profiles: ${{ matrix.profile }}

- uses: actions/upload-artifact@v3
name: Save Logs
if: success() || failure()
- uses: actions/upload-artifact@v4
with:
name: tower-${{ matrix.profile }}-log
name: Seqera Platform debug log file
path: |
tower_action_*.log
tower_action_*.json
seqera_platform_action_*.log
seqera_platform_action_*.json
31 changes: 31 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,37 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [3.5.1](https://github.com/nf-core/sarek/releases/tag/3.5.1) - Akkatjåkkå

Akkatjåkkå is another glacier.

### Added

- [1759](https://github.com/nf-core/sarek/pull/1759) - Back to dev

### Changed

- [1767](https://github.com/nf-core/sarek/pull/1767) - Bump nf-schema version to 2.2.1
- [1777](https://github.com/nf-core/sarek/pull/1777) - Merge intervals for WES in GATK GenomicsDBImport
- [1798](https://github.com/nf-core/sarek/pull/1798) - Prepare release 3.5.1

### Fixed

- [1797](https://github.com/nf-core/sarek/pull/1797) - Use `file-path-pattern` over `file-path` to hanlde glob for `known_indels` and `known_indels_tbi` to fix [1785](https://github.com/nf-core/sarek/issues/1785)
- [1802](https://github.com/nf-core/sarek/pull/1802) - Update GHA for full_test tests

### Removed

### Dependencies

| Dependency | Old version | New version |
| ---------- | ----------- | ----------- |

### Parameters

| Params | Status |
| ------ | ------ |

## [3.5.0](https://github.com/nf-core/sarek/releases/tag/3.5.0) - Áhkájiegna

A set of connecting glaciers.
Expand Down
12 changes: 7 additions & 5 deletions assets/multiqc_config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,10 @@ custom_logo_url: https://github.com/nf-core/sarek/
custom_logo_title: "nf-core/sarek"

report_comment: >
This report has been generated by the <a href="https://github.com/nf-core/sarek/releases/tag/3.5.0" target="_blank">nf-core/sarek</a>
analysis pipeline. For information about how to interpret these results, please see the
<a href="https://nf-co.re/sarek/3.5.0/docs/output" target="_blank">documentation</a>.
This report has been generated by the <a href="https://github.com/nf-core/sarek/releases/tag/3.5.1"
target="_blank">nf-core/sarek</a> analysis pipeline. For information about how to
interpret these results, please see the <a href="https://nf-co.re/sarek/3.5.1/docs/output"
target="_blank">documentation</a>.
report_section_order:
"nf-core-sarek-methods-description":
order: -1000
Expand Down Expand Up @@ -41,7 +42,8 @@ module_order:
name: "FastP (Read preprocessing)"
- picard:
name: "GATK4 MarkDuplicates"
info: " metrics generated either by GATK4 MarkDuplicates or EstimateLibraryComplexity (with --use_gatk_spark)."
info: " metrics generated either by GATK4 MarkDuplicates or EstimateLibraryComplexity
(with --use_gatk_spark)."
- samtools:
name: "Samtools Flagstat"
- mosdepth:
Expand All @@ -63,7 +65,7 @@ extra_fn_clean_exts:
pattern: "^.*.(md|recal).mosdepth.(global|region).dist"
module: mosdepth

sample_names_replace_regex: True
sample_names_replace_regex: true
sample_names_replace:
"\\.[0-9]{4}$": ".md" # should match ".0001" but only at the end of strings for module Markduplicates/EstimateLibraryComplexity
module: picard
Expand Down
4 changes: 3 additions & 1 deletion conf/modules/joint_germline.config
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@
process {

withName: 'GATK4_GENOMICSDBIMPORT' {
ext.args = { '--genomicsdb-shared-posixfs-optimizations true --bypass-feature-reader' }
ext.args = { params.wes ?
'--merge-input-intervals --genomicsdb-shared-posixfs-optimizations true --bypass-feature-reader' :
'--genomicsdb-shared-posixfs-optimizations true --bypass-feature-reader' }
ext.prefix = { "${meta.intervals_name}.joint" }
publishDir = [
enabled: false
Expand Down
20 changes: 10 additions & 10 deletions nextflow.config
Original file line number Diff line number Diff line change
Expand Up @@ -336,14 +336,14 @@ env {
}

// Set bash options
process.shell = """\
bash
set -e # Exit if a tool returns a non-zero status/exit code
set -u # Treat unset variables and parameters as an error
set -o pipefail # Returns the status of the last command to exit with a non-zero status or zero if all successfully execute
set -C # No clobber - prevent output redirection from overwriting files.
"""
process.shell = [
"bash",
"-C", // No clobber - prevent output redirection from overwriting files.
"-e", // Exit if a tool returns a non-zero status/exit code
"-u", // Treat unset variables and parameters as an error
"-o", // Returns the status of the last command to exit..
"pipefail" // ..with a non-zero status or zero if all successfully execute
]

// Disable process selector warnings by default. Use debug profile to enable warnings.
nextflow.enable.configProcessNamesValidation = false
Expand Down Expand Up @@ -381,13 +381,13 @@ manifest {
description = """An open-source analysis pipeline to detect germline or somatic variants from whole genome or targeted sequencing"""
mainScript = 'main.nf'
nextflowVersion = '!>=24.04.2'
version = '3.5.0'
version = '3.5.1'
doi = '10.12688/f1000research.16665.2, 10.1093/nargab/lqae031, 10.5281/zenodo.3476425'
}

// Nextflow plugins
plugins {
id 'nf-schema@2.1.1' // Validation of pipeline parameters and creation of an input channel from a sample sheet
id 'nf-schema@2.2.1' // Validation of pipeline parameters and creation of an input channel from a sample sheet
id '[email protected]' // Provenance reports for pipeline runs
}

Expand Down
4 changes: 2 additions & 2 deletions nextflow_schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -706,7 +706,7 @@
"known_indels": {
"type": "string",
"fa_icon": "fas fa-copy",
"format": "file-path",
"format": "file-path-pattern",
"exists": true,
"mimetype": "text/plain",
"description": "Path to known indels file.",
Expand All @@ -715,7 +715,7 @@
"known_indels_tbi": {
"type": "string",
"fa_icon": "fas fa-copy",
"format": "file-path",
"format": "file-path-pattern",
"exists": true,
"mimetype": "text/plain",
"description": "Path to known indels file index.",
Expand Down
4 changes: 2 additions & 2 deletions tests/aligner-bwa-mem.nf.test.snap
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"samtools": 1.21
},
"Workflow": {
"nf-core/sarek": "v3.5.0"
"nf-core/sarek": "v3.5.1"
}
},
[
Expand Down Expand Up @@ -72,7 +72,7 @@
5,
{
"Workflow": {
"nf-core/sarek": "v3.5.0"
"nf-core/sarek": "v3.5.1"
}
},
[
Expand Down
4 changes: 2 additions & 2 deletions tests/aligner-bwa-mem2.nf.test.snap
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
5,
{
"Workflow": {
"nf-core/sarek": "v3.5.0"
"nf-core/sarek": "v3.5.1"
}
},
[
Expand Down Expand Up @@ -60,7 +60,7 @@
"samtools": 1.21
},
"Workflow": {
"nf-core/sarek": "v3.5.0"
"nf-core/sarek": "v3.5.1"
}
},
[
Expand Down
4 changes: 2 additions & 2 deletions tests/aligner-dragmap.nf.test.snap
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
5,
{
"Workflow": {
"nf-core/sarek": "v3.5.0"
"nf-core/sarek": "v3.5.1"
}
},
[
Expand Down Expand Up @@ -64,7 +64,7 @@
"samtools": 1.21
},
"Workflow": {
"nf-core/sarek": "v3.5.0"
"nf-core/sarek": "v3.5.1"
}
},
[
Expand Down
2 changes: 1 addition & 1 deletion tests/alignment_from_everything.nf.test.snap
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
"vcftools": "0.1.16"
},
"Workflow": {
"nf-core/sarek": "v3.5.0"
"nf-core/sarek": "v3.5.1"
}
},
[
Expand Down
2 changes: 1 addition & 1 deletion tests/alignment_to_fastq.nf.test.snap
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
"vcftools": "0.1.16"
},
"Workflow": {
"nf-core/sarek": "v3.5.0"
"nf-core/sarek": "v3.5.1"
}
},
[
Expand Down
2 changes: 1 addition & 1 deletion tests/annotation_bcfann.nf.test.snap
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"bcftools": 1.2
},
"Workflow": {
"nf-core/sarek": "v3.5.0"
"nf-core/sarek": "v3.5.1"
}
},
[
Expand Down
4 changes: 2 additions & 2 deletions tests/annotation_merge.nf.test.snap
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"tabix": 1.2
},
"Workflow": {
"nf-core/sarek": "v3.5.0"
"nf-core/sarek": "v3.5.1"
}
},
[
Expand Down Expand Up @@ -122,7 +122,7 @@
"tabix": 1.2
},
"Workflow": {
"nf-core/sarek": "v3.5.0"
"nf-core/sarek": "v3.5.1"
}
},
[
Expand Down
2 changes: 1 addition & 1 deletion tests/annotation_snpeff.nf.test.snap
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"tabix": 1.2
},
"Workflow": {
"nf-core/sarek": "v3.5.0"
"nf-core/sarek": "v3.5.1"
}
},
[
Expand Down
2 changes: 1 addition & 1 deletion tests/annotation_vep.nf.test.snap
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"tabix": 1.2
},
"Workflow": {
"nf-core/sarek": "v3.5.0"
"nf-core/sarek": "v3.5.1"
}
},
[
Expand Down
2 changes: 1 addition & 1 deletion tests/default.nf.test.snap
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"vcftools": "0.1.16"
},
"Workflow": {
"nf-core/sarek": "v3.5.0"
"nf-core/sarek": "v3.5.1"
}
},
[
Expand Down
2 changes: 1 addition & 1 deletion tests/save_output_as_bam.nf.test.snap
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"samtools": 1.21
},
"Workflow": {
"nf-core/sarek": "v3.5.0"
"nf-core/sarek": "v3.5.1"
}
},
[
Expand Down
2 changes: 1 addition & 1 deletion tests/saved_mapped.nf.test.snap
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"samtools": 1.21
},
"Workflow": {
"nf-core/sarek": "v3.5.0"
"nf-core/sarek": "v3.5.1"
}
},
[
Expand Down
2 changes: 1 addition & 1 deletion tests/sentieon.nf.test.snap
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"vcftools": "0.1.16"
},
"Workflow": {
"nf-core/sarek": "v3.5.0"
"nf-core/sarek": "v3.5.1"
}
},
[
Expand Down
8 changes: 4 additions & 4 deletions tests/start_from_markduplicates.nf.test.snap
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"samtools": 1.21
},
"Workflow": {
"nf-core/sarek": "v3.5.0"
"nf-core/sarek": "v3.5.1"
}
},
[
Expand Down Expand Up @@ -148,7 +148,7 @@
"samtools": 1.21
},
"Workflow": {
"nf-core/sarek": "v3.5.0"
"nf-core/sarek": "v3.5.1"
}
},
[
Expand Down Expand Up @@ -323,7 +323,7 @@
"samtools": 1.21
},
"Workflow": {
"nf-core/sarek": "v3.5.0"
"nf-core/sarek": "v3.5.1"
}
},
[
Expand Down Expand Up @@ -475,7 +475,7 @@
"samtools": 1.21
},
"Workflow": {
"nf-core/sarek": "v3.5.0"
"nf-core/sarek": "v3.5.1"
}
},
[
Expand Down
Loading

0 comments on commit 5fe5cdf

Please sign in to comment.