Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: chore: bump gh actions to v4 because node dep #35

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

td-famedly
Copy link
Member

This will break your flows if you use @V3. td went ahead and bumped everything in frontend to v4 already so this is a quick hack for now.

Setting to draft/wip until someone actually invests time in this migration.

Copy link

* d018c63fda9e690c6f539a779155ae0034c1ea8f chore: bump gh actions to v4 because node dep
|   - Authorized by td <[email protected]> [6402F3BA59C5FA18]
* d8a62968e8835a7204719b72d05ff9715d23e756 feat(authenticate-commits): add reusable workflow for commit authentication
    - Trust root.

The pull request's base (d8a6296) authenticates the pull request's head (d018c63).

@@ -121,7 +121,7 @@ jobs:
touch "/tmp/digests/${digest#sha256:}"

- name: Upload digest
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: digests-${{ inputs.registry }}-${{ inputs.image_name }}-${{ steps.tag.outputs.tags }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work, each artifact needs a unique name in v4. This upload to the same name for every matrix entry.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(slashes aren't valid either, need to fix that after sleeping :))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current state looks like it's the only way forward, I suppose we don't need to build docker images for platforms other than linux anyway.

Anything else still holding this up? The workflow has been deprecated at this point, so we should get this through.

Copy link

* 88fade5bb60d8a96bbcbab7d0049f72b86730e5f fix: merging digests with actions/upload-artifact@v4
|   - Authorized by Nicolas Werner <[email protected]> [5FA6B2A02D13B144]
* d018c63fda9e690c6f539a779155ae0034c1ea8f chore: bump gh actions to v4 because node dep
|   - Authorized by td <[email protected]> [6402F3BA59C5FA18]
* d8a62968e8835a7204719b72d05ff9715d23e756 feat(authenticate-commits): add reusable workflow for commit authentication
    - Trust root.

The pull request's base (d8a6296) authenticates the pull request's head (88fade5).

Copy link

* ee607603040bbfd8b300f42ec7294280e1fc587a fix: merging digests with actions/upload-artifact@v4
|   - Authorized by Nicolas Werner <[email protected]> [5FA6B2A02D13B144]
* d018c63fda9e690c6f539a779155ae0034c1ea8f chore: bump gh actions to v4 because node dep
|   - Authorized by td <[email protected]> [6402F3BA59C5FA18]
* d8a62968e8835a7204719b72d05ff9715d23e756 feat(authenticate-commits): add reusable workflow for commit authentication
    - Trust root.

The pull request's base (d8a6296) authenticates the pull request's head (ee60760).

Copy link

github-actions bot commented Feb 4, 2025

* 597134d3c9ce40aa5b2ca12f8236483dab96a20c chore: bump gh actions to v4 because node dep
|   - Error: Key `04DBCD97497E9DC6A53C1C72B1A438A411D12AC8` missing
* 8a17531ae1c1dce31cae95e82eb015dbbc0c373e feat: Add inputs to specify runner size
    - Trust root.

Failed to authenticate commits.

Error: Could not verify commits 8a17531ae1c1dce31cae95e82eb015dbbc0c373e..597134d3c9ce40aa5b2ca12f8236483dab96a20c

Caused by:
    0: While verifying commit 597134d3c9ce40aa5b2ca12f8236483dab96a20c
    1: Key `04DBCD97497E9DC6A53C1C72B1A438A411D12AC8` missing

@tlater-famedly
Copy link

Rebased the branch, looks fine to me, but clearly I have no permissions to do anything here at the minute ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants