-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: chore: bump gh actions to v4 because node dep #35
base: main
Are you sure you want to change the base?
Conversation
The pull request's base (d8a6296) authenticates the pull request's head (d018c63). |
.github/workflows/docker.yml
Outdated
@@ -121,7 +121,7 @@ jobs: | |||
touch "/tmp/digests/${digest#sha256:}" | |||
|
|||
- name: Upload digest | |||
uses: actions/upload-artifact@v3 | |||
uses: actions/upload-artifact@v4 | |||
with: | |||
name: digests-${{ inputs.registry }}-${{ inputs.image_name }}-${{ steps.tag.outputs.tags }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't work, each artifact needs a unique name in v4. This upload to the same name for every matrix entry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(slashes aren't valid either, need to fix that after sleeping :))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Current state looks like it's the only way forward, I suppose we don't need to build docker images for platforms other than linux
anyway.
Anything else still holding this up? The workflow has been deprecated at this point, so we should get this through.
The pull request's base (d8a6296) authenticates the pull request's head (88fade5). |
88fade5
to
ee60760
Compare
The pull request's base (d8a6296) authenticates the pull request's head (ee60760). |
ee60760
to
6c01ae7
Compare
6c01ae7
to
597134d
Compare
Failed to authenticate commits.
|
Rebased the branch, looks fine to me, but clearly I have no permissions to do anything here at the minute ;) |
This will break your flows if you use @V3. td went ahead and bumped everything in frontend to v4 already so this is a quick hack for now.
Setting to draft/wip until someone actually invests time in this migration.