Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make user localparts non-optional #111

Merged
merged 3 commits into from
Feb 13, 2025
Merged

Conversation

tlater-famedly
Copy link
Contributor

No description provided.

@tlater-famedly tlater-famedly force-pushed the tlater/debug-migration branch 4 times, most recently from 103403a to 5832fc3 Compare February 13, 2025 07:49
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 97.00855% with 7 lines in your changes missing coverage. Please review.

Project coverage is 93.16%. Comparing base (727c4d9) to head (7ddbd2a).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/lib.rs 90.47% 2 Missing ⚠️
src/sources/csv.rs 88.23% 2 Missing ⚠️
src/zitadel.rs 97.75% 2 Missing ⚠️
src/user.rs 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #111      +/-   ##
==========================================
+ Coverage   92.86%   93.16%   +0.29%     
==========================================
  Files           9        9              
  Lines        1669     1771     +102     
==========================================
+ Hits         1550     1650     +100     
- Misses        119      121       +2     
Files with missing lines Coverage Δ
src/bin/migrate.rs 99.02% <100.00%> (+0.19%) ⬆️
src/sources/ldap.rs 96.85% <100.00%> (+0.05%) ⬆️
src/user.rs 90.67% <87.50%> (-1.89%) ⬇️
src/lib.rs 86.33% <90.47%> (-0.80%) ⬇️
src/sources/csv.rs 94.84% <88.23%> (+0.05%) ⬆️
src/zitadel.rs 97.75% <97.75%> (+1.02%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 727c4d9...7ddbd2a. Read the comment docs.

@tlater-famedly tlater-famedly marked this pull request as ready for review February 13, 2025 08:11
@tlater-famedly tlater-famedly requested a review from a team as a code owner February 13, 2025 08:11
mzaniolo
mzaniolo previously approved these changes Feb 13, 2025
Since localparts from ldap syncs would end up empty, this resulted in
lots of spurious logging about user updates that weren't actually
happening.

This gets rid of that by mapping types better to what's actually
happening.
@tlater-famedly tlater-famedly merged commit 7ddbd2a into main Feb 13, 2025
5 checks passed
@tlater-famedly tlater-famedly deleted the tlater/debug-migration branch February 13, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants