Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend documentation given some real user experience #104

Merged
merged 3 commits into from
Jan 15, 2025
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,12 @@ Currently supported sources:

## Configuration

> [!WARNING]
>
> When creating a service user, limit them to the specific project and
> organization scope that they are intended to sync. `famedly-sync`
> currently does not separately limit the scope of the sync, see #103.

The tool expects a configuration file located at `./config.yaml`. See example configuration at [config.sample.yaml](./config.sample.yaml).

The default path can be changed by setting the new path to the environment variable `FAMEDLY_SYNC_CONFIG`.
Expand Down Expand Up @@ -121,7 +127,7 @@ docker compose up
Or alternatively, without `docker compose`:

```
docker run --rm -it --network host --volume ./opt:/opt/famedly-sync-agent docker-oss.nexus.famedly.de/famedly-sync-agent:latest
docker run --rm -it --network host --volume ./opt:/opt/famedly-sync docker-oss.nexus.famedly.de/famedly-sync-agent:latest
jannden marked this conversation as resolved.
Show resolved Hide resolved
```

### Kubernetes Deployment
Expand Down
2 changes: 1 addition & 1 deletion docker-compose.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@ services:
volumes:
- type: bind
source: ./opt
target: /opt/famedly-sync-agent
target: /opt/famedly-sync
network_mode: host
2 changes: 1 addition & 1 deletion ldap-sync-cronjob.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ spec:
image: docker-oss.nexus.famedly.de/famedly-sync-agent:v0.4.0
imagePullPolicy: IfNotPresent
volumeMounts:
- mountPath: /opt/famedly-sync-agent/
- mountPath: /opt/famedly-sync/
name: famedly-sync-config
restartPolicy: OnFailure
volumes:
Expand Down
6 changes: 5 additions & 1 deletion sample-configs/csv-config.sample.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,16 @@ zitadel:
# The Famedly user endpoint to sync to.
url: https://auth.famedly.de
# The Famedly-provided service user credentials.
key_file: /opt/famedly-sync-agent/service-user.json
key_file: /opt/famedly-sync/service-user.json
# The organization whose users to sync.
organization_id: 278274756195721220
# The project to grant users access to.
project_id: 278274945274880004
# The identity provider ID to enable SSO login for
#
# WARNING: This user *must* be scoped to the specific org/project,
# as famedly-sync does not limit syncs to the configured org/project
# by itself.
idp_id: 281430143275106308

feature_flags:
Expand Down
6 changes: 5 additions & 1 deletion sample-configs/ldap-config.sample.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,16 @@ zitadel:
# The Famedly user endpoint to sync to.
url: https://auth.famedly.de
# The Famedly-provided service user credentials.
key_file: /opt/famedly-sync-agent/service-user.json
key_file: /opt/famedly-sync/service-user.json
# The organization whose users to sync.
organization_id: 278274756195721220
# The project to grant users access to.
project_id: 278274945274880004
# The identity provider ID to enable SSO login for
#
# WARNING: This user *must* be scoped to the specific org/project,
# as famedly-sync does not limit syncs to the configured org/project
# by itself.
idp_id: 281430143275106308

feature_flags:
Expand Down
6 changes: 5 additions & 1 deletion sample-configs/ukt-config.sample.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,16 @@ zitadel:
# The Famedly user endpoint to sync to.
url: https://auth.famedly.de
# The Famedly-provided service user credentials.
key_file: /opt/famedly-sync-agent/service-user.json
key_file: /opt/famedly-sync/service-user.json
# The organization whose users to sync.
organization_id: 278274756195721220
# The project to grant users access to.
project_id: 278274945274880004
# The identity provider ID to enable SSO login for
#
# WARNING: This user *must* be scoped to the specific org/project,
# as famedly-sync does not limit syncs to the configured org/project
# by itself.
idp_id: 281430143275106308

feature_flags:
Expand Down
Loading