Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(netbox): initial role #34

Merged
1 commit merged into from
Apr 18, 2024
Merged

feat(netbox): initial role #34

1 commit merged into from
Apr 18, 2024

Conversation

evlli
Copy link
Contributor

@evlli evlli commented Mar 19, 2024

No description provided.

@evlli evlli force-pushed the evlli/netbox branch 3 times, most recently from 636a382 to fe6b0f9 Compare March 25, 2024 12:38
@evlli evlli marked this pull request as ready for review April 12, 2024 13:27
@evlli evlli requested a review from a team as a code owner April 12, 2024 13:27
@evlli evlli requested a review from jcgruenhage April 12, 2024 13:27
jcgruenhage
jcgruenhage suggested changes Apr 12, 2024
View reviewed changes
roles/netbox/README.md Outdated Show resolved Hide resolved
roles/netbox/defaults/main.yml Outdated Show resolved Hide resolved
roles/netbox/defaults/main.yml Outdated Show resolved Hide resolved
roles/netbox/defaults/main.yml Outdated Show resolved Hide resolved
roles/netbox/defaults/main.yml Outdated Show resolved Hide resolved
roles/netbox/defaults/main.yml Outdated Show resolved Hide resolved
roles/netbox/tasks/main.yml Outdated Show resolved Hide resolved
roles/netbox/tasks/main.yml Outdated Show resolved Hide resolved
roles/netbox/tasks/main.yml Outdated Show resolved Hide resolved
roles/netbox/templates/loader.py Outdated Show resolved Hide resolved
@evlli evlli force-pushed the evlli/netbox branch 2 times, most recently from 347a3a5 to bba3eb2 Compare April 12, 2024 15:41
@evlli evlli requested a review from jcgruenhage April 12, 2024 15:44
jcgruenhage
jcgruenhage suggested changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@jcgruenhage jcgruenhage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more minor problems, but it's getting there

roles/netbox/defaults/main.yml Outdated Show resolved Hide resolved
roles/netbox/handlers/main.yml Show resolved Hide resolved
roles/netbox/defaults/main.yml Outdated Show resolved Hide resolved
@evlli evlli force-pushed the evlli/netbox branch 2 times, most recently from 08d5127 to 7f85542 Compare April 15, 2024 09:11
@evlli evlli requested a review from jcgruenhage April 16, 2024 07:16
@evlli evlli self-assigned this Apr 16, 2024
jcgruenhage
jcgruenhage suggested changes Apr 16, 2024
View reviewed changes
roles/netbox/tasks/main.yml Outdated Show resolved Hide resolved
@evlli evlli requested a review from jcgruenhage April 18, 2024 09:15
@evlli evlli closed this pull request by merging all changes into main in 403177a Apr 18, 2024
@evlli evlli deleted the evlli/netbox branch April 18, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcgruenhage jcgruenhage jcgruenhage approved these changes

Assignees

@evlli evlli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evlli @jcgruenhage