Use existing translation keys #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add location coordinates to location links - correctly group locations with only coordinates - use translation keys - align placemark icon to top of text
|
Maybe this code is safe enough to merge, anything that is broken by the changes will be fairly obvious. We can come back to existing translations any time, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #538
I've made too many issues ;) with the idea they'll be good for people to work on bit by bit, but instead, it was easier for me to do them at once:
Closes #587
Closes #588
Closes #590
Closes #591
Closes #592
Closes #637
Also addresses #622 (comment)
Also the branch has some refactoring to the "entry"/ location pages - I started from those aiming to improve the review summary, but then got pulled into applying the existing translations.
To demonstrate that the epic is complete, here's a locale file with only translation keys that are not used anywhere in the code:
locale-with-only-old-keys.txt
I've been reading through version of that file and finding functionality that should still be translated, and now I can't any more, but @ezwelty maybe you'll spot functionality worth bringing over from the old site?
I've not tried to use translations from the mobile app, since it's not been translated into all the languages, but maybe I'll be able to use them for AI translation as context.
After this change, I propose to move to the next stages of translating: tidying up the existing json, moving verbiage out of the code and into the locale files, and then some kind of AI translation phase.