Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loongarch64 support #28

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Add loongarch64 support #28

merged 1 commit into from
Apr 22, 2024

Conversation

yzewei
Copy link
Contributor

@yzewei yzewei commented Jan 12, 2024

The LoongArch architecture (LoongArch) is an Instruction Set Architecture (ISA) that has a RISC style.

@poiana
Copy link

poiana commented Jan 12, 2024

Welcome @yzewei! It looks like this is your first PR to falcosecurity/syscalls-bumper 🎉

@poiana poiana added the size/XS label Jan 12, 2024
@FedeDP
Copy link
Collaborator

FedeDP commented Jan 12, 2024

Hi! Thanks for opening this PR! Are you planning to add support for loongarch to drivers?

@FedeDP
Copy link
Collaborator

FedeDP commented Jan 12, 2024

/hold

@yzewei
Copy link
Contributor Author

yzewei commented Jan 12, 2024

Hi! Thanks for opening this PR! Are you planning to add support for loongarch to drivers?

This is what I want to do @FedeDP

@FedeDP
Copy link
Collaborator

FedeDP commented Jan 12, 2024

Yay! Thanks! Keeping this on hold until PRs get merged on libs then ;)

@yzewei
Copy link
Contributor Author

yzewei commented Jan 12, 2024

Yay! Thanks! Keeping this on hold until PRs get merged on libs then ;)

There seems to be no problem.

@FedeDP
Copy link
Collaborator

FedeDP commented Apr 22, 2024

Closing and reopening to trigger CI!
/close

@poiana poiana closed this Apr 22, 2024
@poiana
Copy link

poiana commented Apr 22, 2024

@FedeDP: Closed this PR.

In response to this:

Closing and reopening to trigger CI!
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@FedeDP
Copy link
Collaborator

FedeDP commented Apr 22, 2024

/reopen

@poiana poiana reopened this Apr 22, 2024
@poiana
Copy link

poiana commented Apr 22, 2024

@FedeDP: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@FedeDP
Copy link
Collaborator

FedeDP commented Apr 22, 2024

/unhold

@FedeDP
Copy link
Collaborator

FedeDP commented Apr 22, 2024

@yzewei can you rebase this one on latest main?

Copy link
Collaborator

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link

poiana commented Apr 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, yzewei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Apr 22, 2024

LGTM label has been added.

Git tree hash: 8286428b84b4be973a391020013033aee0107be1

@poiana poiana merged commit c9b2052 into falcosecurity:main Apr 22, 2024
3 checks passed
@yzewei
Copy link
Contributor Author

yzewei commented Apr 23, 2024

can you rebase this one on latest main?

@FedeDP Sorry, I just saw it.

@FedeDP
Copy link
Collaborator

FedeDP commented Apr 23, 2024

No problem :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants