fix(driver): use configure system to check for mnt_idmap for fs #2247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poiana
added
release-note-none
kind/bug
|
Please double check driver/SCHEMA_VERSION file. See versioning. /hold |
FedeDP
approved these changes
Jan 20, 2025
|
/milestone next-driver |
FedeDP
requested changes
Jan 20, 2025
LucaGuerra
previously approved these changes
Jan 20, 2025
|
LGTM label has been added. Git tree hash: 5dfe7bb845271bdd976daa10453713fe29cfdfdf
|
Perf diff from master - unit testsHeap diff from master - unit testsHeap diff from master - scap fileBenchmarks diff from master |
Kernel 6.3 changed fs functions to `struct mnt_idmap`. Use the configure system in place of the version check to support driver build on RHEL 9 (namely 5.14.0-547.el9.x86_64) Signed-off-by: Angelo Puglisi <[email protected]>
deepskyblue86
force-pushed
the
kmod/fs_mnt_idmap
branch
from
18b3044 to
95a0ce9
Compare
Looks like CentOS Stream 9 has |
|
LGTM label has been added. Git tree hash: d80fe92ecd12f425f2fe456a34e54d8bc7c9ecf0
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deepskyblue86, FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
False positive. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2247 +/- ##
=======================================
Coverage 75.12% 75.12%
=======================================
Files 276 276
Lines 34399 34399
Branches 5922 5922
=======================================
Hits 25841 25841
Misses 8558 8558
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
LucaGuerra
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area driver-kmod
Does this PR require a change in the driver versions?
What this PR does / why we need it:
Kernel 6.3 changed fs functions to
struct mnt_idmap.Use the configure system in place of the version check to support driver build on RHEL 9 (namely 5.14.0-547.el9.x86_64).
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
It's possible to reproduce the issue with a CentOS Stream 9. I use vagrant with
boxomatic/centos-stream-9image.Does this PR introduce a user-facing change?: