-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sinsp): Support 'mmap' and 'mmap2' system calls filtering by fd values #1832
Conversation
Welcome @eddyduer-sysdig! It looks like this is your first PR to falcosecurity/libs 🎉 |
Please double check driver/SCHEMA_VERSION file. See versioning. /hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @eddyduer-sysdig thanks for the contribution. Few points for proceeding:
- If the PR is ready for review, please remove the Draft status so that other maintainers will know they can take a look
- Make sure you sign-off all your commit as that's a requirement for our governance
@FedeDP do we usually bump the SCHEMA version minor/patch when we change the EF_*
flags of events, like in this case?
6e3ca05
to
393ee65
Compare
…red using the fd parameter Signed-off-by: Eddy Duer <[email protected]>
Signed-off-by: Eddy Duer <[email protected]>
393ee65
to
c99ca62
Compare
/milestone next-driver |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 342d1580030f0cef45458fcbbaf3928ec6d8ab44
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, eddyduer-sysdig, FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area driver-kmod
/area driver-bpf
/area driver-modern-bpf
/area libsinsp
Does this PR require a change in the driver versions?
/version driver-SCHEMA-version-minor
What this PR does / why we need it:
Parser assumed that FD is always first. For mmap and mmap2 this is not the case, so parsing using any of the FD fields (e.g. fd.name) did not work
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: