Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sinsp): Support 'mmap' and 'mmap2' system calls filtering by fd values #1832

Merged
merged 2 commits into from
May 7, 2024

Conversation

eddyduer-sysdig
Copy link
Contributor

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libsinsp

Does this PR require a change in the driver versions?

/version driver-SCHEMA-version-minor

What this PR does / why we need it:

Parser assumed that FD is always first. For mmap and mmap2 this is not the case, so parsing using any of the FD fields (e.g. fd.name) did not work

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix: filtering for 'mmap' and 'mmap2' using fd values

@poiana
Copy link
Contributor

poiana commented May 3, 2024

Welcome @eddyduer-sysdig! It looks like this is your first PR to falcosecurity/libs 🎉

@poiana poiana added the size/M label May 3, 2024
Copy link

github-actions bot commented May 3, 2024

Please double check driver/SCHEMA_VERSION file. See versioning.

/hold

@jasondellaluce jasondellaluce changed the title Fix(sinsp): Support 'mmap' and 'mmap2' system calls filtering by fd values fix(sinsp): Support 'mmap' and 'mmap2' system calls filtering by fd values May 3, 2024
Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @eddyduer-sysdig thanks for the contribution. Few points for proceeding:

  • If the PR is ready for review, please remove the Draft status so that other maintainers will know they can take a look
  • Make sure you sign-off all your commit as that's a requirement for our governance

@FedeDP do we usually bump the SCHEMA version minor/patch when we change the EF_* flags of events, like in this case?

@FedeDP
Copy link
Contributor

FedeDP commented May 7, 2024

/milestone next-driver

@poiana poiana added this to the next-driver milestone May 7, 2024
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label May 7, 2024
@poiana
Copy link
Contributor

poiana commented May 7, 2024

LGTM label has been added.

Git tree hash: 342d1580030f0cef45458fcbbaf3928ec6d8ab44

@poiana poiana added the approved label May 7, 2024
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented May 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, eddyduer-sysdig, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jasondellaluce
Copy link
Contributor

/unhold

@poiana poiana merged commit d67ff09 into falcosecurity:master May 7, 2024
49 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants