fix: potentially uninitialized variables

Signed-off-by: Federico Aponte <[email protected]>
falcosecurity · Dec 6, 2023 · 6509c8e · 6509c8e
1 parent 2809baf
commit 6509c8e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/test/libscap/test_suites/engines/gvisor/gvisor_parsers.cpp b/test/libscap/test_suites/engines/gvisor/gvisor_parsers.cpp
@@ -405,11 +405,10 @@ TEST(gvisor_parsers, small_buffer)
 
 TEST(gvisor_parsers, procfs_entry)
 {
-    scap_gvisor::parsers::procfs_result res;
     std::string not_json = "not a json string";
     std::string sandbox_id = "deadbeef";
 
-    res = scap_gvisor::parsers::parse_procfs_json(not_json, sandbox_id);
+    scap_gvisor::parsers::procfs_result res = scap_gvisor::parsers::parse_procfs_json(not_json, sandbox_id);
     EXPECT_EQ(res.status, SCAP_FAILURE);
 
     std::string json = R"(

diff --git a/userspace/libscap/engine/gvisor/gvisor.h b/userspace/libscap/engine/gvisor/gvisor.h
@@ -50,11 +50,11 @@ struct parse_result {
     // description of the error in case of failure
 	std::string error;
     // the total encoded event(s) size
-	size_t size;
+	size_t size = 0;
     // pointers to each encoded event within the supplied output buffer
 	std::vector<scap_evt*> scap_events;
     // number of events dropped by gVisor
-    uint32_t dropped_count;
+    uint32_t dropped_count = 0;
 };
 
 struct procfs_result {

diff --git a/userspace/libscap/engine/gvisor/parsers.cpp b/userspace/libscap/engine/gvisor/parsers.cpp
@@ -2135,6 +2135,7 @@ parse_result parse_gvisor_proto(scap_const_sized_buffer gvisor_buf, scap_sized_b
 procfs_result parse_procfs_json(const std::string &input, const std::string &sandbox)
 {
 	procfs_result res;
+	memset(&res.tinfo, 0, sizeof(res.tinfo));
 	Json::Value root;
 	Json::CharReaderBuilder builder;
 	std::string err;