fix: only toggle the navbar button if it's visible #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgriffs
approved these changes
Apr 7, 2021
vytas7
approved these changes
Apr 7, 2021
| @@ -111,7 +111,9 @@ function handleClick() { | |||
| return; | |||
| } | |||
| document.getElementById('navbarPrimary').addEventListener('click', function(event) { | |||
| button.click(); | |||
| if(getComputedStyle(button).display !== 'none'){ | |||
There was a problem hiding this comment.
Not sure about the indentation and whitespace standards in this project, if any.
Shouldn't we add a space after if, and before {?
There was a problem hiding this comment.
we could add prettier or something, but I think it could be another issue
There was a problem hiding this comment.
Good enough for me. I just noticed the surrounding code does have spaces in these places.
There was a problem hiding this comment.
I use the builtin formatter of vscode and for js/ts does just the bare minimum, so it will not add/remove the spaced there.
There was a problem hiding this comment.
opened #63 just as a reminder if we want to go that way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #61