Skip to content

Commit

Permalink
Simplify the Gulp usage described on the README (google#4063)
Browse files Browse the repository at this point in the history
* Simplify the Gulp usage, this way is not needed to have it installed globally

* Add a pre start script to build the application before start the server.
  • Loading branch information
murielsilveira authored and petele committed Jan 26, 2017
1 parent f510926 commit e8d99db
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
9 changes: 4 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@ git clone https://github.com/google/WebFundamentals.git

## Getting set up
The new DevSite infrastructure simplifies the dependencies a lot. Ensure
you have a recent version of [Node](https://nodejs.org/en/),
[Gulp](http://gulpjs.com/) and the
you have a recent version of [Node](https://nodejs.org/en/) and the
[AppEngine SDK for Python](https://cloud.google.com/appengine/downloads#Google_App_Engine_SDK_for_Python)
already installed.

Expand All @@ -42,7 +41,7 @@ this is done for you. However, when you add a case study, update, etc., you'll
need to re-build those files using:

```
gulp build
npm run build
```

## Update the code labs
Expand All @@ -58,11 +57,11 @@ access to the original Doc files. This will likely only work for Googlers.
1. Run `npm start`

## Test your changes before submitting a PR
Please run your changes through gulp test before submitting a PR. The test
Please run your changes through npm test before submitting a PR. The test
looks for things that may cause issues with DevSite and tries to keep our
content consistent. It's part of the deployment process, so PRs will fail
if there are any errors! To run:

```
gulp test
npm test
```
3 changes: 3 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@
},
"scripts": {
"postinstall": "gulp build",
"build": "gulp build",
"test": "gulp test",
"prestart": "gulp build",
"start": "./start-appengine.sh"
}
}

0 comments on commit e8d99db

Please sign in to comment.