Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP Organize, use RXJS for observableGrillStatus, use events, add tests. #2

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

WIP Organize, use RXJS for observableGrillStatus, use events, add tests. #2

wants to merge 5 commits into from

Conversation

facultymatt
Copy link
Owner

@facultymatt facultymatt commented Apr 19, 2020 •
edited
Loading

Goal is to save events into database for things like

  • grill on / off / fan mode / cold smoke mode
  • grill / probe desired temp change
  • low pellet alarm active
  • desired temp reached

Approach is to make observable grill state, and use rxjs operators to know when conditions change, and save events into database.

Re-org based on https://softwareontheroad.com/ideal-nodejs-project-structure/, worked well for this project.

TODO

  • Change to do lots of short connections to grill is proving less stable than in master, where we keep one grill connection open for getting status.
  • strange unexpected events are getting into database like probTempChange with null temp. Need to debug this

@facultymatt facultymatt changed the title WIP Re org WIP Organize, use RXJS for observableGrillStatus, use events for temp change, etc. May 2, 2020
@facultymatt facultymatt changed the title WIP Organize, use RXJS for observableGrillStatus, use events for temp change, etc. WIP Organize, use RXJS for observableGrillStatus, use events. May 2, 2020
@facultymatt facultymatt changed the title WIP Organize, use RXJS for observableGrillStatus, use events. WIP Organize, use RXJS for observableGrillStatus, use events, add tests. May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@facultymatt