Skip to content

Commit

Permalink
Fix a minor bug about generate_video (#879)
Browse files Browse the repository at this point in the history
* Fix a minor bug about `generate_video`

`fps` is not passed to `images_to_video`

* Update common.py

Follow black format
  • Loading branch information
Jiayuan-Gu authored Jun 5, 2022
1 parent 5ce36a6 commit 2ec4f68
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion habitat_baselines/utils/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,9 @@ def generate_video(
)
if "disk" in video_option:
assert video_dir is not None
images_to_video(images, video_dir, video_name, verbose=verbose)
images_to_video(
images, video_dir, video_name, fps=fps, verbose=verbose
)
if "tensorboard" in video_option:
tb_writer.add_video_from_np_images(
f"episode{episode_id}", checkpoint_idx, images, fps=fps
Expand Down

0 comments on commit 2ec4f68

Please sign in to comment.