Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

Update Readme to load & run pretrained embeddings directly. (Possible #240) #241

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

srbhr
Copy link

@srbhr srbhr commented Nov 28, 2021

Checking on #240 I've added a way to work with pretrained embedding directly in order to load/run pretrained models with the help of Weaviate.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context / Related issue

Q: Why is this change required? What problem does it solve?
A: In regards to the issue discussed in #240 I propose a solution to easily work with pre-trained embeddings in order to load/work with them easily.

Q: Please link to an existing issue here if one exists.
A: Possible #240

How Has This Been Tested (if it applies)

Q: Please describe here how your modifications have been tested.
A: It's a markdown and is Able to merge with main.

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document and completed the CLA (see CONTRIBUTING).
  • All tests passed, and additional code has been covered with new tests.

Adding a section titled "Working with Pre-Trained Embeddings"  adding details on how you can run the embedding directly (and hassle free) with Weaviate.
Adding a section to Pre-Trained Embeddings
@facebook-github-bot
Copy link
Contributor

Hi @srbhr!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 28, 2021
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants