feat: cache invalidation on .babelrc update #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
mellyeliu
force-pushed
the
cli-cache-babel
branch
from
5db7b69 to
3c60939
Compare
workflow: benchmarks/sizeComparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.
|
nmn
requested changes
Jan 18, 2025
Comment on lines
+25
to
+31
| try { | ||
| await fs.access(babelrcPath); | ||
| console.log('Found babelrc:', babelrcPath); | ||
| return babelrcPath; | ||
| } catch { | ||
| currentDir = path.dirname(currentDir); | ||
| } |
There was a problem hiding this comment.
Don't use fs.access. Use fs.exists instead. That returns a boolean and won't throw an error.
There was a problem hiding this comment.
https://nodejs.org/api/fs.html#fs_fs_exists_path_callback fs.exists is deprecated and may cause issues with modern node versions. if error specificity isn't a concern we can use fs.exists but it might require updates later, which could impact maintainability
|
Also needs to be rebased. |
mellyeliu
force-pushed
the
cli-cache-babel
branch
from
49c27bc to
92ea4fb
Compare
mellyeliu
force-pushed
the
cli-cache-babel
branch
from
92ea4fb to
fa5182c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed / motivation ?
Let's add cache invalidation on .babelrc config update
Testing
Added tests writing .babelrc update
Pre-flight checklist
Contribution Guidelines