Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace crypto with murmurhash for cli caching #850

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Conversation

mellyeliu
Copy link
Member

@mellyeliu mellyeliu commented Jan 13, 2025

What changed / motivation ?

murmurhash is in fact faster than crypto, and we don't need the added security for caching. let's switch for consistency

Testing

tests pass, yolo

Pre-flight checklist

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 13, 2025
@mellyeliu mellyeliu requested a review from nmn January 13, 2025 00:12
Copy link

workflow: benchmarks/size

Comparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.

@stylexjs/[email protected] size:compare
./size-compare.js /tmp/tmp.4ElE5GNC5t /tmp/tmp.f4eLZsLNrI

Results Base Patch Ratio
stylex/lib/stylex.js
· compressed 729 729 1.00
· minified 2,541 2,541 1.00
stylex/lib/StyleXSheet.js
· compressed 1,266 1,266 1.00
· minified 3,776 3,776 1.00
rollup-example/.build/bundle.js
· compressed 567,110 567,110 1.00
· minified 10,232,512 10,232,512 1.00
rollup-example/.build/stylex.css
· compressed 100,626 100,626 1.00
· minified 757,176 757,176 1.00

@mellyeliu mellyeliu merged commit d16e60e into main Jan 13, 2025
8 checks passed
@mellyeliu mellyeliu deleted the cli-cache-m branch January 13, 2025 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants