Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: playground sidebar #826

Closed

Conversation

aminaopio
Copy link
Contributor

@aminaopio aminaopio commented Dec 23, 2024

What changed / motivation ?

The StyleX website has an empty-ish page for the playground. This partially tackles one of the issues: A source editor pane that support tabs for multiple files. Includes:

  • Drag and drop functionality for src directory
  • Loading indicator while WebContainer is booting
  • CRUD file operation/rendering and error handling courtesy of @6ri4n

Linked PR/Issues

Helps address #732

Additional Context

feat826

Screenshot 2024-12-27 at 9 21 38 AM Screenshot 2024-12-27 at 9 22 02 AM

Pre-flight checklist

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 23, 2024
@aminaopio aminaopio marked this pull request as ready for review December 23, 2024 23:40
@aminaopio aminaopio force-pushed the even-better-playground branch from 3a37e96 to 96ea090 Compare December 23, 2024 23:55
@aminaopio aminaopio changed the title feature: playground sidebar w/ loading indicator/dropzone feature: playground sidebar Dec 24, 2024
@aminaopio aminaopio changed the title feature: playground sidebar feat: playground sidebar Dec 24, 2024
@aminaopio
Copy link
Contributor Author

@nmn Rebased even-better-playground onto better-playground. There shouldn't be any conflicts this time, but there are some checks failing

@nonzzz
Copy link
Contributor

nonzzz commented Dec 24, 2024

I think you should make this pull request commit as clean as possible. Now i note this pull request contain the main branch commit it's not need.

@nonzzz
Copy link
Contributor

nonzzz commented Dec 24, 2024

Some ides. I think you can create a new branch based on the latest commit of the main branch. then using cherry-pick pick this 96ea090cc4371211c23891efc76d502fac939209 to the new branch.

@nmn
Copy link
Contributor

nmn commented Dec 27, 2024

@nonzzz is correct.

All the relevant changes for this PR are for the website that doesn't use types or tests. So none of the signals should be red once your PR is clean.

@aminaopio
Copy link
Contributor Author

@nmn Sorry this took so long.

I fixed a majority of the lint errors, but the remaining ones are caused by the pseudo elements. I think the version of the ESLint plugin that we're using is outdated/not supported anymore.

Not too sure about the performance size error

@nonzzz
Copy link
Contributor

nonzzz commented Dec 27, 2024

wait. I'll check your work at my local. If everything goes as expected, will you invite me to be a collaborator?

@aminaopio
Copy link
Contributor Author

Yeah I can do that, just let me know!

nmn and others added 4 commits December 27, 2024 23:36
Improve compilation to not insert inject calls

Add Vercel headers

Configure local development for playground

Add codemirror editor

Use rollup and static server.

Delay preview to wait for built files

chore: update to latest StyleX for playground

chore: fix build

chore: playground actually builds

chore: rebase and reinstall
feat: allow file editing and updates the preview
update reload button

fix: cleanup and improve perf
@nonzzz
Copy link
Contributor

nonzzz commented Dec 27, 2024

I do some change and pretty your commit in my local and put it at cleaned you can view and check my branch and invite me as the collaborator.( If it's ok, i'll force push into your branch)

@nonzzz
Copy link
Contributor

nonzzz commented Dec 27, 2024

And i check the lint rule it not outdated.

@aminaopio
Copy link
Contributor Author

I do some change and pretty your commit in my local and put it at cleaned you can view and check my branch and invite me as the collaborator.( If it's ok, i'll force push into your branch)

Invited you as a collaborator @nonzzz, I tested on your branch and got different linting errors than the ones above. I can fix them if they pop up here

And i check the lint rule it not outdated.

And hmm okay—the errors I was getting were the same that were resolved in #320, but not getting them on your branch so should be good. Thanks for the help!

@nonzzz
Copy link
Contributor

nonzzz commented Dec 28, 2024

@aminaopio Should be closed and create a new one .I have synchronized some of the playground work to the last commit of the main branch.

@nonzzz
Copy link
Contributor

nonzzz commented Dec 28, 2024

And then modifications must be based on the synchronized branch.
image

@aminaopio
Copy link
Contributor Author

@aminaopio Should be closed and create a new one .I have synchronized some of the playground work to the last commit of the main branch.

I believe Naman wanted us to base it off of better-playground since it's not ready to be merged into main yet. Maybe he can clarify @nmn. Are you saying create another PR?

@nonzzz
Copy link
Contributor

nonzzz commented Dec 28, 2024

Because the development was not synchronized in time, the history of this PR carries a lot of unnecessary noise. I think creating a new PR will be clearer, and as you said, we need clarify by @nmn

@nmn nmn force-pushed the better-playground branch from 8c15b00 to af2c2da Compare January 3, 2025 21:06
@nmn nmn deleted the branch facebook:better-playground January 3, 2025 21:16
@nmn nmn closed this Jan 3, 2025
@aminaopio aminaopio deleted the even-better-playground branch January 4, 2025 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants