-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: playground sidebar #826
feat: playground sidebar #826
Conversation
3a37e96
to
96ea090
Compare
@nmn Rebased even-better-playground onto better-playground. There shouldn't be any conflicts this time, but there are some checks failing |
I think you should make this pull request commit as clean as possible. Now i note this pull request contain the main branch commit it's not need. |
Some ides. I think you can create a new branch based on the latest commit of the main branch. then using |
@nonzzz is correct. All the relevant changes for this PR are for the website that doesn't use types or tests. So none of the signals should be red once your PR is clean. |
96ea090
to
a34f8e8
Compare
96ea090
to
c3db434
Compare
c3db434
to
6a8fd47
Compare
@nmn Sorry this took so long. I fixed a majority of the lint errors, but the remaining ones are caused by the pseudo elements. I think the version of the ESLint plugin that we're using is outdated/not supported anymore. Not too sure about the performance size error |
wait. I'll check your work at my local. If everything goes as expected, will you invite me to be a collaborator? |
Yeah I can do that, just let me know! |
Improve compilation to not insert inject calls Add Vercel headers Configure local development for playground Add codemirror editor Use rollup and static server. Delay preview to wait for built files chore: update to latest StyleX for playground chore: fix build chore: playground actually builds chore: rebase and reinstall
feat: allow file editing and updates the preview update reload button fix: cleanup and improve perf
I do some change and pretty your commit in my local and put it at cleaned you can view and check my branch and invite me as the collaborator.( If it's ok, i'll force push into your branch) |
And i check the lint rule it not outdated. |
Invited you as a collaborator @nonzzz, I tested on your branch and got different linting errors than the ones above. I can fix them if they pop up here
And hmm okay—the errors I was getting were the same that were resolved in #320, but not getting them on your branch so should be good. Thanks for the help! |
408adc9
to
cb7d652
Compare
cb7d652
to
edc9b2a
Compare
@aminaopio Should be closed and create a new one .I have synchronized some of the playground work to the last commit of the main branch. |
I believe Naman wanted us to base it off of better-playground since it's not ready to be merged into main yet. Maybe he can clarify @nmn. Are you saying create another PR? |
Because the development was not synchronized in time, the history of this PR carries a lot of unnecessary noise. I think creating a new PR will be clearer, and as you said, we need clarify by @nmn |
What changed / motivation ?
The StyleX website has an empty-ish page for the playground. This partially tackles one of the issues: A source editor pane that support tabs for multiple files. Includes:
src
directoryLinked PR/Issues
Helps address #732
Additional Context
Pre-flight checklist
Contribution Guidelines