Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Babel plugin should no longer require unstable_moduleResolution.rootDir #820

Merged
merged 4 commits into from
Dec 21, 2024
Merged

fix: Babel plugin should no longer require unstable_moduleResolution.rootDir #820

merged 4 commits into from
Dec 21, 2024

Conversation

nmn
Copy link
Contributor

@nmn nmn commented Dec 21, 2024 •
edited
Loading

What changed / motivation ?

unstable_moduleResolution.rootDir should now always be optional.

I tested this change with the nextjs-example as our tests don't read files for now.

Fixes #818

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 21, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 21, 2024 •
edited
Loading

workflow: benchmarks/size

Comparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.

@stylexjs/[email protected] size:compare
./size-compare.js /tmp/tmp.CeaVDuiv1z /tmp/tmp.Mdv8DlrqCx

Results Base Patch Ratio
stylex/lib/stylex.js
· compressed 729 729 1.00
· minified 2,541 2,541 1.00
stylex/lib/StyleXSheet.js
· compressed 1,266 1,266 1.00
· minified 3,776 3,776 1.00
rollup-example/.build/bundle.js
· compressed 567,110 567,110 1.00
· minified 10,232,512 10,232,512 1.00
rollup-example/.build/stylex.css
· compressed 100,626 100,626 1.00
· minified 757,176 757,176 1.00

@nmn nmn merged commit c43e68a into main Dec 21, 2024
8 checks passed
aminaopio pushed a commit to aminaopio/stylex that referenced this pull request Dec 22, 2024
@nmn @aminaopio
fix: Babel plugin should no longer require `unstable_moduleResolutio…
f8c7b5f 
…n.rootDir` (facebook#820)
aminaopio pushed a commit to aminaopio/stylex that referenced this pull request Dec 22, 2024
@nmn @aminaopio
fix: Babel plugin should no longer require `unstable_moduleResolutio…
c2e9fe3 
…n.rootDir` (facebook#820)
@nmn nmn deleted the fix/optional-rootDir branch December 22, 2024 08:29
aminaopio pushed a commit to aminaopio/stylex that referenced this pull request Dec 23, 2024
@nmn @aminaopio
fix: Babel plugin should no longer require `unstable_moduleResolutio…
22b84f3 
…n.rootDir` (facebook#820)
aminaopio pushed a commit to aminaopio/stylex that referenced this pull request Dec 27, 2024
@nmn @aminaopio
fix: Babel plugin should no longer require `unstable_moduleResolutio…
b1718ce 
…n.rootDir` (facebook#820)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@necolas necolas necolas approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stylex 0.9.3 still requires rootDir for unstable_moduleResolution
3 participants
@nmn @necolas @facebook-github-bot