Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rollup plugin support generate file with pattern #815

Merged
merged 2 commits into from
Dec 23, 2024

Conversation

nonzzz
Copy link
Contributor

@nonzzz nonzzz commented Dec 18, 2024

What changed / motivation ?

Until now I found that no one has implemented it.

Linked PR/Issues

Fixes #778

Additional Context

Screenshots, Tests, Anything Else

Pre-flight checklist

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 18, 2024
Copy link
Contributor

@nmn nmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes suggested.

packages/rollup-plugin/src/index.js Outdated Show resolved Hide resolved
@nmn
Copy link
Contributor

nmn commented Dec 23, 2024

Thanks!

@nmn nmn merged commit 347ebef into facebook:main Dec 23, 2024
7 of 8 checks passed
aminaopio pushed a commit to aminaopio/stylex that referenced this pull request Dec 23, 2024
* feat: rollup plugin support generate file with pattern
* feat(rollup-plugin): hash should respect file content
aminaopio pushed a commit to aminaopio/stylex that referenced this pull request Dec 27, 2024
* feat: rollup plugin support generate file with pattern
* feat(rollup-plugin): hash should respect file content
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[hash] in fileName
3 participants