Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor cli cache tests to be async #804

Merged
merged 1 commit into from
Dec 10, 2024
Merged

chore: refactor cli cache tests to be async #804

merged 1 commit into from
Dec 10, 2024

Conversation

mellyeliu
Copy link
Member

@mellyeliu mellyeliu commented Dec 6, 2024 •
edited
Loading

Context

Follow up to #790 and #792

Let's clean up the tests and move to async functions

Pre-flight checklist

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 6, 2024
@mellyeliu mellyeliu marked this pull request as draft December 6, 2024 21:31
@mellyeliu mellyeliu marked this pull request as ready for review December 10, 2024 04:31
@mellyeliu mellyeliu requested a review from nmn December 10, 2024 04:31
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 10, 2024 •
edited
Loading

workflow: benchmarks/size

Comparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.

@stylexjs/[email protected] size:compare
./size-compare.js /tmp/tmp.QKYtFo3fei /tmp/tmp.x5mTDqKuHZ

Results Base Patch Ratio
stylex/lib/stylex.js
· compressed 729 729 1.00
· minified 2,541 2,541 1.00
stylex/lib/StyleXSheet.js
· compressed 1,266 1,266 1.00
· minified 3,776 3,776 1.00
rollup-example/.build/bundle.js
· compressed 562,983 562,983 1.00
· minified 10,185,368 10,185,368 1.00
rollup-example/.build/stylex.css
· compressed 99,229 99,229 1.00
· minified 745,845 745,845 1.00

nmn
nmn approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@nmn nmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

packages/cli/__tests__/compile-stylex-folder-test.js Show resolved Hide resolved
@mellyeliu mellyeliu merged commit 92f98e7 into main Dec 10, 2024
8 checks passed
@nmn nmn deleted the cli-cache-chore branch December 10, 2024 19:55
aminaopio pushed a commit to aminaopio/stylex that referenced this pull request Dec 22, 2024
@mellyeliu @aminaopio
chore: make cli testing async (facebook#804)
2349be1
aminaopio pushed a commit to aminaopio/stylex that referenced this pull request Dec 22, 2024
@mellyeliu @aminaopio
chore: make cli testing async (facebook#804)
c34c72a
aminaopio pushed a commit to aminaopio/stylex that referenced this pull request Dec 23, 2024
@mellyeliu @aminaopio
chore: make cli testing async (facebook#804)
53b0557
aminaopio pushed a commit to aminaopio/stylex that referenced this pull request Dec 27, 2024
@mellyeliu @aminaopio
chore: make cli testing async (facebook#804)
1dce659
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmn nmn nmn approved these changes

@necolas necolas Awaiting requested review from necolas

@Prakshal-Jain Prakshal-Jain Awaiting requested review from Prakshal-Jain

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mellyeliu @nmn @facebook-github-bot