-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve documentation website #8
Conversation
compressed-size: runtime library Size change: 0.00 kB View unchanged
|
compressed-size: e2e bundles Size change: 0.00 kB View unchanged
|
More changes to "Thinking in StyleX"
|
patterns in CSS impossible: e.g. It is currently impossible for a child element | ||
to have conditional styles when it's parent is hovered. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be removed since below we describe how child elements can have conditional styles when parents are hovered - using variables
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to make this simpler and more vague.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple more minor issues. I think the <details>
rendering that you're using to collapse bundler examples doesn't look great right now. And the options shown for each of the bundlers are different.
Also noticed a few "bad patterns" in the CSS for the docs themselves, which brings up the question of what is still supported in the OSS release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to unblock as it's basically there!
Latest link: https://stylex-docusaurus-jpo0wgtgl-nmn.vercel.app |
Made the following improvements:
Preview Link: https://stylex-docusaurus-11zzqvnrr-nmn.vercel.app